r83008 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83007‎ | r83008 | r83009 >
Date:08:52, 1 March 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Per Reedy, fix for r82034: forgot to change a wfGetCacheNotice() call (and also changed a comment)
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1567,7 +1567,7 @@
15681568 $parserMemc->set( $key, array( 'html' => $parsed, 'hash' => md5( $notice ) ), 600 );
15691569 $notice = $parsed;
15701570 } else {
1571 - wfDebug( 'wfGetCachedNotice called for ' . $name . ' with no $wgOut available' . "\n" );
 1571+ wfDebug( 'Skin::getCachedNotice called for ' . $name . ' with no $wgOut available' . "\n" );
15721572 $notice = '';
15731573 }
15741574 }
@@ -1586,7 +1586,7 @@
15871587 wfProfileIn( __METHOD__ );
15881588
15891589 $key = 'namespacenotice-' . $this->mTitle->getNsText();
1590 - $namespaceNotice = wfGetCachedNotice( $key );
 1590+ $namespaceNotice = $this->getCachedNotice( $key );
15911591 if ( $namespaceNotice && substr( $namespaceNotice, 0, 7 ) != '<p>&lt;' ) {
15921592 $namespaceNotice = '<div id="namespacebanner">' . $namespaceNotice . '</div>';
15931593 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82034Moved wfGetSiteNotice(), wfGetNamespaceNotice() and wfGetCachedNotice() to Sk...ialex21:24, 12 February 2011

Comments

#Comment by Reedy (talk | contribs)   11:34, 1 March 2011

Cheers :)

#Comment by Reedy (talk | contribs)   11:34, 1 March 2011

Cheers :)

Status & tagging log