r82967 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82966‎ | r82967 | r82968 >
Date:21:33, 28 February 2011
Author:purodha
Status:reverted (Comments)
Tags:
Comment:
bug 27793 - Babel box header shows link anchor text in user language, and link target from content language.
See also http://translatewiki.net/wiki/Thread:Support/Babel_translation appearing only partially
Modified paths:
  • /trunk/extensions/Babel/Babel.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Babel/Babel.class.php
——@@ -54,7 +54,7 @@
5555
5656 $cellspacing = wfMsgForContent( 'babel-box-cellspacing' );
5757 $url = wfMsgForContent( 'babel-url' );
58 - $top = wfMsgExt( 'babel', array( 'parsemag', 'content' ), self::$title->getDBkey() );
 58+ $top = wfMsgExt( 'babel', array( 'parsemag' ), self::$title->getDBkey() );
5959 $tower = <<<EOT
6060 {| cellspacing="$cellspacing" class="mw-babel-wrapper"
6161 ! [[$url|$top]]

Follow-up revisions

RevisionCommit summaryAuthorDate
r83385Revert r82967 per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82967#...siebrand16:17, 6 March 2011
r103786(bug 27793) Make a config variable ($wgBabelUseUserLanguage) to make the "Bab...bawolff21:27, 20 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   22:03, 28 February 2011

This is wrong. Now the text can be anything depending on the language of the user who viewed the page first.

#Comment by RobertL (talk | contribs)   06:44, 1 March 2011

I think that's the point.

#Comment by RobertL (talk | contribs)   06:43, 1 March 2011

If you insist on having this, please can you make it subject to a configuration option? I believe this as it is will result in users receiving the header in a seemingly random language due to page caching.

#Comment by Purodha (talk | contribs)   21:46, 12 March 2011

Postponed for the time being. There are so many things that need to be done before we have the means that this can be fixed, that I am afraid it'll take many months to get them all done.

Status & tagging log