r82922 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82921‎ | r82922 | r82923 >
Date:00:05, 28 February 2011
Author:mah
Status:reverted (Comments)
Tags:
Comment:
Add mime type/info for .eml files
Modified paths:
  • /trunk/phase3/includes/mime.info (modified) (history)
  • /trunk/phase3/includes/mime.types (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/mime.types
——@@ -163,3 +163,4 @@
164164 application/x-opc+zip docx dotx docm dotm potx ppsx pptx ppam pptm potm ppsm xlsx xltx xlsm xltm xlam xlsb dwfx xps
165165 application/vnd.google-earth.kml+xml kml
166166 application/vnd.google-earth.kmz kmz
 167+message/rfc822 eml
Index: trunk/phase3/includes/mime.info
——@@ -57,6 +57,7 @@
5858 video/x-msvideo [MULTIMEDIA]
5959
6060 text/plain [TEXT]
 61+message/rfc822 [TEXT]
6162 text/html application/xhtml+xml [TEXT]
6263 application/xml text/xml [TEXT]
6364 text [TEXT]

Follow-up revisions

RevisionCommit summaryAuthorDate
r86161Revert r82922 (adding eml files to mime types). Per CR, these should be accom...demon00:16, 16 April 2011

Comments

#Comment by Hashar (talk | contribs)   20:34, 25 March 2011

i am afraid this could be used to distribute a zip / exe / .com or some other nasty virus. MIME messages can encapsulate just anything :(

#Comment by MarkAHershberger (talk | contribs)   00:29, 26 March 2011

True. I knew I should have added some sanity checking code when I did this.

Thanks for pointing that out! And thanks for reviewing!

#Comment by 😂 (talk | contribs)   15:29, 27 March 2011

Would be best to just revert for now, pending the checks described above.

Status & tagging log