r82803 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82802‎ | r82803 | r82804 >
Date:17:21, 25 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Display userid, and actually put username in user (like usual)

Fix up a bad description
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryFilearchive.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryFilearchive.php
@@ -69,7 +69,10 @@
7070 $this->addFields( 'fa_name' );
7171 $this->addFieldsIf( 'fa_storage_key', $fld_sha1 );
7272 $this->addFieldsIf( 'fa_timestamp', $fld_timestamp );
73 - $this->addFieldsIf( 'fa_user', $fld_user );
 73+
 74+ if ( $fld_user ) {
 75+ $this->addFields( array( 'fa_user', 'fa_user_text' ) );
 76+ }
7477 $this->addFieldsIf( 'fa_size', $fld_size );
7578
7679 if ( $fld_dimensions ) {
@@ -137,7 +140,8 @@
138141 $file['timestamp'] = wfTimestamp( TS_ISO_8601, $row->fa_timestamp );
139142 }
140143 if ( $fld_user ) {
141 - $file['user'] = $row->fa_user;
 144+ $file['userid'] = $row->fa_user;
 145+ $file['user'] = $row->fa_user_text;
142146 }
143147 if ( $fld_size ) {
144148 $file['size'] = $row->fa_size;
@@ -227,7 +231,7 @@
228232 'What image information to get:',
229233 ' sha1 - Adds SHA-1 hash for the image',
230234 ' timestamp - Adds timestamp for the uploaded version',
231 - ' user - Adds user for uploaded the image version',
 235+ ' user - Adds user who uploaded the image version',
232236 ' size - Adds the size of the image in bytes',
233237 ' dimensions - Adds the height and width of the image',
234238 ' description - Adds description the image version',

Follow-up revisions

RevisionCommit summaryAuthorDate
r82805MFT r82803reedy18:16, 25 February 2011
r82806MFT r82803reedy18:17, 25 February 2011

Status & tagging log