r82747 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82746‎ | r82747 | r82748 >
Date:20:58, 24 February 2011
Author:ialex
Status:deferred
Tags:
Comment:
* Use an extension function rather than SetupAfterCache hook when delaying settings extraction.
* Some cleanup for 0.16.0
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/Configure.func.php (modified) (history)
  • /trunk/extensions/Configure/Configure.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/CHANGELOG
@@ -1,7 +1,11 @@
22 This file lists changes on this extension. Localisation updates are done
33 through translatewiki.net and are not listed here.
44
5 -0.16.0 - 22 February 2010
 5+0.16.1 - 24 Februara 2011
 6+ Use an extension function rather than SetupAfterCache hook when delaying
 7+ settings extraction.
 8+
 9+0.16.0 - 22 February 2011
610 Rewrote the extension to use the ressource loader and jQuery.
711 THIS VERSION NOW REQUIRES MediaWiki 1.17 TO WORK.
812
Index: trunk/extensions/Configure/Configure.func.php
@@ -39,8 +39,8 @@
4040
4141 if ( $wgConfigureAllowDeferSetup && $wgConfigureHandler == 'db' ) {
4242 // Defer to after caches and database are set up.
43 - global $wgHooks;
44 - $wgHooks['SetupAfterCache'][] = array( 'efConfigureInitialise' );
 43+ global $wgExtensionFunctions;
 44+ $wgExtensionFunctions[] = 'efConfigureInitialise';
4545 } else {
4646 efConfigureInitialise();
4747 }
Index: trunk/extensions/Configure/Configure.php
@@ -17,7 +17,7 @@
1818 'author' => array( 'Alexandre Emsenhuber', 'Andrew Garrett' ),
1919 'url' => 'http://www.mediawiki.org/wiki/Extension:Configure',
2020 'descriptionmsg' => 'configure-desc',
21 - 'version' => '0.16.0',
 21+ 'version' => '0.16.1',
2222 );
2323
2424 # Configuration part
@@ -281,8 +281,8 @@
282282
283283 # Ressource loader
284284 $wgResourceModules['ext.configure'] = array(
285 - 'scripts' => 'configure.js',
286 - 'styles' => 'configure.css',
 285+ 'scripts' => 'Configure.js',
 286+ 'styles' => 'Configure.css',
287287
288288 'messages' => array(
289289 'configure-js-add',

Status & tagging log