r82642 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82641‎ | r82642 | r82643 >
Date:23:26, 22 February 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Partial revert r82636 after fixing swapped parameters in r82641
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialTypes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialTypes.php
@@ -33,16 +33,7 @@
3434
3535 list( $limit, $offset ) = wfCheckLimits();
3636
37 - // When the QueryPage class was changed in r78786, the order of these
38 - // parameters was conveniently swapped around. Brilliant for introducing
39 - // subtle bugs; we ought to do it more!
40 - if ( method_exists( 'QueryPage', 'getQueryInfo' ) ) {
41 - $rep->doQuery( $limit, $offset );
42 - $rep->execute( array() );
43 - }
44 - else {
45 - $rep->doQuery( $offset, $limit );
46 - }
 37+ $rep->doQuery( $offset, $limit );
4738
4839 // Ensure locally collected output data is pushed to the output!
4940 SMWOutputs::commitToOutputPage( $wgOut );

Follow-up revisions

RevisionCommit summaryAuthorDate
r82671fix page again after r82642 and r82641jeroendedauw14:35, 23 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82636fix bug 27440jeroendedauw22:30, 22 February 2011
r82641Followup r78786, per complaints on r82636, revert parameter ordering...reedy23:22, 22 February 2011

Comments

#Comment by Jeroen De Dauw (talk | contribs)   14:09, 23 February 2011

Special page not showing anything any more. How nice that after 2 hours of tracking down this bug and fixing it, someone comes along to "make it better", then breaks it, does not do any testing, and commits it. I'm sure it's not intended to, but that's a little offensive.

#Comment by Jeroen De Dauw (talk | contribs)   14:35, 23 February 2011

Fixed in follow up

Status & tagging log