r82447 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82446‎ | r82447 | r82448 >
Date:12:05, 19 February 2011
Author:catrope
Status:ok
Tags:
Comment:
Partial revert of r54986: passing true for an array parameter that's type-hinted as such causes a fatal error
Modified paths:
  • /trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php
@@ -160,7 +160,7 @@
161161 closedir( $dir );
162162
163163 // Find the changed English strings (as these messages won't be updated in ANY language).
164 - $changedEnglishStrings = self::compareFiles( $localdir . '/MessagesEn.php', $svndir . '/MessagesEn.php', $verbose, true );
 164+ $changedEnglishStrings = self::compareFiles( $localdir . '/MessagesEn.php', $svndir . '/MessagesEn.php', $verbose );
165165
166166 // Count the changes.
167167 $changedCount = 0;

Follow-up revisions

RevisionCommit summaryAuthorDate
r824501.17wmf1: MFT r82447, r82448catrope12:33, 19 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54986No sense re-parsing unchanged files just because we're loading them off local...brion00:06, 14 August 2009

Status & tagging log