r82439 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82438‎ | r82439 | r82440 >
Date:08:01, 19 February 2011
Author:maxsem
Status:resolved
Tags:
Comment:
Bug 27053 - sourceFile() didn't expand all the required variables. Apparently, broken by r81084
Modified paths:
  • /trunk/phase3/includes/installer/MysqlInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/MysqlInstaller.php
@@ -430,8 +430,8 @@
431431 return $status;
432432 }
433433
434 - $db = $this->getVar( 'wgDBname' );
435434 $this->db->selectDB( $db );
 435+ $this->setupSchemaVars();
436436 $error = $this->db->sourceFile( "$IP/maintenance/users.sql" );
437437 if ( $error !== true ) {
438438 $status->fatal( 'config-install-user-failed', $this->getVar( 'wgDBuser' ), $error );
@@ -463,6 +463,9 @@
464464 public function getSchemaVars() {
465465 return array(
466466 'wgDBTableOptions' => $this->getTableOptions(),
 467+ 'wgDBname' => $this->getVar( 'wgDBname' ),
 468+ 'wgDBuser' => $this->getVar( 'wgDBuser' ),
 469+ 'wgDBpassword' => $this->getVar( 'wgDBpassword' ),
467470 );
468471 }
469472

Follow-up revisions

RevisionCommit summaryAuthorDate
r82517Revert errorneous line removal in r82439maxsem16:53, 20 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81084* Fixed Oracle new installer support, broken by r80957. This is a minimal pat...tstarling08:25, 27 January 2011

Status & tagging log