r82424 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82423‎ | r82424 | r82425 >
Date:23:42, 18 February 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r49655

I'd guess there's never been a Title::newFromTitle method, swapping for Title::newFromText
Modified paths:
  • /trunk/phase3/includes/filerepo/LocalRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/LocalRepo.php
——@@ -85,7 +85,7 @@
8686 global $wgMemc;
8787
8888 if( is_string( $title ) ) {
89 - $title = Title::newFromTitle( $title );
 89+ $title = Title::newFromText( $title );
9090 }
9191 if( $title instanceof Title && $title->getNamespace() == NS_MEDIA ) {
9292 $title = Title::makeTitle( NS_FILE, $title->getText() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49655Move checkRedirect() from FileRepo to LocalRepo, leaving only a stub behind. ...tstarling03:06, 20 April 2009

Comments

#Comment by 😂 (talk | contribs)   15:55, 18 April 2011

Title::newFromTitle()? I'd say somebody's been watching Inception but the commit predates the movie ;-)

Status & tagging log