r82369 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82368‎ | r82369 | r82370 >
Date:01:00, 18 February 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Fix wrong static calls
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/Providers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/Providers.php
@@ -32,8 +32,8 @@
3333 public function DaysMonths() {
3434 $ret = array();
3535
36 - $months = self::Months();
37 - $days = self::Days();
 36+ $months = $this->Months();
 37+ $days = $this->Days();
3838 foreach( $months as $month) {
3939 foreach( $days as $day ) {
4040 $ret[] = array( $day[0], $month[0] );

Follow-up revisions

RevisionCommit summaryAuthorDate
r83665Makes MediaWikiProvide methods static...hashar20:24, 10 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81607Move some providers in new MediaWikiProvide class...hashar21:28, 6 February 2011

Comments

#Comment by Hashar (talk | contribs)   10:30, 1 March 2011

All those functions should be made static

#Comment by Hashar (talk | contribs)   20:24, 10 March 2011

Made static with r83665

Status & tagging log