r82243 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82242‎ | r82243 | r82244 >
Date:13:58, 16 February 2011
Author:catrope
Status:reverted (Comments)
Tags:
Comment:
1.17wmf1: Revert r71051 on CategoryTree per vvv's suggestion
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/CategoryTree/CategoryPageSubclass.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/CategoryTree/CategoryPageSubclass.php
@@ -1,7 +1,15 @@
22 <?php
33
44 class CategoryTreeCategoryPage extends CategoryPage {
5 - protected $mCategoryViewerClass = 'CategoryTreeCategoryViewer';
 5+ function closeShowCategory() {
 6+ global $wgOut, $wgRequest;
 7+
 8+ $from = $wgRequest->getVal( 'from' );
 9+ $until = $wgRequest->getVal( 'until' );
 10+
 11+ $viewer = new CategoryTreeCategoryViewer( $this->mTitle, $from, $until );
 12+ $wgOut->addHTML( $viewer->getHTML() );
 13+ }
614 }
715
816 class CategoryTreeCategoryViewer extends CategoryViewer {

Sign-offs

UserFlagDate
Simetricalinspected00:03, 17 February 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r835611.17wmf1: Revert r82243. This should make the (next 200) links work againcatrope00:43, 9 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71051Fix extensions to work with category sort changes...simetrical22:07, 13 August 2010

Comments

#Comment by Siebrand (talk | contribs)   15:48, 16 February 2011

There are no CR comments at r71051, so it might be nice to document the background on this revert.

#Comment by Catrope (talk | contribs)   14:58, 18 February 2011

The background is that mCategoryViewerClass was part of the category collation changes and was reverted in 1.17wmf1, but this code wasn't.

#Comment by Simetrical (talk | contribs)   23:13, 16 February 2011

I'm about 85% sure this will break pagination, although I haven't tested yet.

#Comment by Simetrical (talk | contribs)   00:03, 17 February 2011

Oh, wait, never mind. I forgot that 1.17wmf has the categorylinks stuff reverted. So this looks good to me.

Status & tagging log