r82189 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82188‎ | r82189 | r82190 >
Date:20:14, 15 February 2011
Author:reedy
Status:deferred
Tags:
Comment:
Fix double indenting, fix double newlines

Param documentation
Modified paths:
  • /trunk/extensions/Translate/TranslateEditAddons.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateEditAddons.php
@@ -19,6 +19,7 @@
2020
2121 /**
2222 * Add some tabs for navigation for users who do not use Ajax interface.
 23+ * @param $skin Skin
2324 */
2425 static function addNavigationTabs( $skin, &$tabs ) {
2526 global $wgRequest;
@@ -34,7 +35,6 @@
3536 return true;
3637 }
3738
38 -
3939 $collection = $group->initCollection( 'en' );
4040 $collection->filter( 'optional' );
4141 $keys = array_keys( $collection->keys() );
@@ -43,6 +43,7 @@
4444 $key = strtolower( strtr( $key, ' ', '_' ) );
4545
4646 $next = $prev = null;
 47+
4748 foreach ( $keys as $index => $tkey ) {
4849 if ( $key === strtolower( strtr( $tkey, ' ', '_' ) ) ) {
4950 break;
@@ -59,7 +60,6 @@
6061 $next = $keys[$index+1];
6162 }
6263
63 -
6464 $id = $group->getId();
6565 $ns = $title->getNamespace();
6666
@@ -107,12 +107,12 @@
108108 }
109109
110110 protected static function addTab( $skin, &$tabs, $name, $data, &$index ) {
111 - if ( $skin instanceof SkinVector ) {
112 - $data['class'] = false; // Vector needs it for some reason
113 - $tabs['namespaces'][$name] = $data;
114 - } else {
115 - array_splice( $tabs, $index++, 0, array( $name => $data ) );
116 - }
 111+ if ( $skin instanceof SkinVector ) {
 112+ $data['class'] = false; // Vector needs it for some reason
 113+ $tabs['namespaces'][$name] = $data;
 114+ } else {
 115+ array_splice( $tabs, $index++, 0, array( $name => $data ) );
 116+ }
117117 }
118118
119119 /**
@@ -378,7 +378,6 @@
379379 $dbw->insert( 'revtag', $conds, __METHOD__ );
380380 }
381381
382 -
383382 // Diffs for changed messages.
384383 if ( $fuzzy !== false ) {
385384 return true;

Status & tagging log