r82188 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82187‎ | r82188 | r82189 >
Date:20:07, 15 February 2011
Author:kipcool
Status:deferred
Tags:
Comment:
corrected another bug with checkboxes
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/forms.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/forms.php
@@ -31,9 +31,9 @@
3232 // therefore the value of a disabled, but checked, checkbox must be sent with a hidden input
3333 if ( $disabled ) {
3434 if ( $isChecked ) {
35 - return '<input disabled="disabled" type="checkbox" name="' . $name . checkBoxCheckAttribute( $isChecked ) . '/><input type="hidden" name="' . $name . '" value="1"/>';
 35+ return '<input disabled="disabled" type="checkbox" name="' . $name . '"' . checkBoxCheckAttribute( $isChecked ) . '/><input type="hidden" name="' . $name . '" value="1"/>';
3636 } else {
37 - return '<input disabled="disabled" type="checkbox" name="' . $name . checkBoxCheckAttribute( $isChecked ) . '/>';
 37+ return '<input disabled="disabled" type="checkbox" name="' . $name . '"' . checkBoxCheckAttribute( $isChecked ) . '/>';
3838 }
3939 } else {
4040 return '<input type="checkbox" name="' . $name . '"' . checkBoxCheckAttribute( $isChecked ) . '/>';

Status & tagging log