r82169 MediaWiki - Code Review archive

The mAddReference is probably used elsewhere and expected to be an int. It looks like a potential injection.

You want to clean up the 'r' just after retrieving user submitted data from the wgRequest object. This way you are sure nobody will use unsecured data later on and avoid code duplication. Code example for ui/CodeRevisionView.php :

$tmp = $wgRequest->getArray( 'wpAddReference', array() );
$this->mAddReference = intval( ltrim( $tmp, 'r' ) );

That won't directly work...

As your trying to ltrim and array, and then intval it.

We could array_map( 'intval', $array )

But we can't do an array_map to do the ltrim with a parameter of 'r'...

simplest way is seemingly to just

$res = array();
foreach( $array as $a ) {
$a = ltrim( $a, 'r' );
$a = intval( $a );

if ( $a ) {
$res[] = $a;
}
}

Or condense it slightly

$array = array_map( array( $this, 'ltrimIntval' ), $array );

	private function ltrimIntval( $item ) {
		$item = ltrim( $item, 'r' );
		return intval( $item );
	}

Much better / safer :)