r82135 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82134‎ | r82135 | r82136 >
Date:20:20, 14 February 2011
Author:reedy
Status:resolved
Tags:
Comment:
* (bug 27405) Special:Code should hide checkboxes when the user can't use them
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
@@ -487,7 +487,9 @@
488488 array_map( array( $this, 'formatReferenceInline' ), $this->mRev->getReferences() )
489489 );
490490 $header = '<th></th>';
491 - $header .= '<th>' . wfMsgHtml( 'code-field-id' ) . '</th>';
 491+ if ( $showButtons ) {
 492+ $header .= '<th>' . wfMsgHtml( 'code-field-id' ) . '</th>';
 493+ }
492494 $header .= '<th>' . wfMsgHtml( 'code-field-message' ) . '</th>';
493495 $header .= '<th>' . wfMsgHtml( 'code-field-author' ) . '</th>';
494496 $header .= '<th>' . wfMsgHtml( 'code-field-timestamp' ) . '</th>';

Follow-up revisions

RevisionCommit summaryAuthorDate
r82142Followup r82135, only show checkbox if neededreedy21:00, 14 February 2011
r82143Fix fail from r82135reedy21:01, 14 February 2011
r82144Similar to bug 27405 / r82135...reedy21:06, 14 February 2011

Status & tagging log