r81994 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81993‎ | r81994 | r81995 >
Date:20:56, 11 February 2011
Author:demon
Status:ok
Tags:
Comment:
MFT r81672
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/DoubleWiki (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/DoubleWiki/DoubleWiki_body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/DoubleWiki/DoubleWiki_body.php
@@ -109,7 +109,6 @@
110110 return true;
111111 }
112112
113 -
114113 /*
115114 * Format the text as a two-column table with aligned paragraphs
116115 */
@@ -193,8 +192,6 @@
194193 return $head . $body . "</table>" ;
195194 }
196195
197 -
198 -
199196 /*
200197 * Split text and return a set of html-balanced paragraphs
201198 */
@@ -223,7 +220,6 @@
224221 return $result;
225222 }
226223
227 -
228224 /*
229225 * Split text and return a set of html-balanced slices
230226 */
@@ -255,7 +251,6 @@
256252 $opening = '';
257253
258254 for( $i=0 ; $i < $n ; $i++) {
259 - $bits = preg_split( $this->tags, $left_slices[$i] );
260255 preg_match_all( $this->tags, $left_slices[$i], $m, PREG_SET_ORDER);
261256 $counter = 0;
262257 for($k=0 ; $k < count($m) ; $k++) {
@@ -264,7 +259,7 @@
265260 $counter++;
266261 array_push($stack, $t);
267262 } else {
268 - $tt = array_pop($stack);
 263+ array_pop($stack);
269264 $counter--;
270265 }
271266 }
@@ -278,7 +273,7 @@
279274 } else if( $i == $n - 1 ) {
280275 $left_slices[$i] = $opening . $left_slices[$i];
281276 } else if( $counter != 0 ) {
282 - $left_slices[$i+1] = $left_slices[$i] . $left_slices[$i+1];
 277+ $left_slices[$i + 1] = $left_slices[$i] . $left_slices[$i+1];
283278 $left_slices[$i] = '';
284279 }
285280 }
Property changes on: branches/wmf/1.17wmf1/extensions/DoubleWiki
___________________________________________________________________
Added: svn:mergeinfo
286281 Merged /trunk/extensions/DoubleWiki:r81672
287282 Merged /branches/sqlite/extensions/DoubleWiki:r58211-58321
288283 Merged /trunk/phase3/extensions/DoubleWiki:r79828,79830,79848,79853,79950-79951,79954,79989,80006-80007,80013,80016,80080,80083,80124,80128,80238,81833
289284 Merged /branches/new-installer/phase3/extensions/DoubleWiki:r43664-66004
290285 Merged /branches/wmf-deployment/extensions/DoubleWiki:r60970
291286 Merged /branches/REL1_15/phase3/extensions/DoubleWiki:r51646
292287 Merged /branches/wmf/1.16wmf4/extensions/DoubleWiki:r67177,69199,76243,77266

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81672Remove unused $bits = preg_split( $this->tags, $left_slices[$i] );...reedy00:58, 8 February 2011

Status & tagging log