r81993 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81992‎ | r81993 | r81994 >
Date:20:56, 11 February 2011
Author:demon
Status:ok
Tags:
Comment:
MFT r81672
Modified paths:
  • /branches/REL1_17/extensions/DoubleWiki (modified) (history)
  • /branches/REL1_17/extensions/DoubleWiki/DoubleWiki_body.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/extensions/DoubleWiki/DoubleWiki_body.php
@@ -109,7 +109,6 @@
110110 return true;
111111 }
112112
113 -
114113 /*
115114 * Format the text as a two-column table with aligned paragraphs
116115 */
@@ -193,8 +192,6 @@
194193 return $head . $body . "</table>" ;
195194 }
196195
197 -
198 -
199196 /*
200197 * Split text and return a set of html-balanced paragraphs
201198 */
@@ -223,7 +220,6 @@
224221 return $result;
225222 }
226223
227 -
228224 /*
229225 * Split text and return a set of html-balanced slices
230226 */
@@ -253,7 +249,6 @@
254250 */
255251 $stack = array();
256252 for( $i=0 ; $i < $n ; $i++) {
257 - $bits = preg_split( $this->tags, $left_slices[$i] );
258253 preg_match_all( $this->tags, $left_slices[$i], $m, PREG_SET_ORDER);
259254 $counter = 0;
260255 for($k=0 ; $k < count($m) ; $k++) {
@@ -262,7 +257,7 @@
263258 $counter++;
264259 array_push($stack, $t);
265260 } else {
266 - $tt = array_pop($stack);
 261+ array_pop($stack);
267262 $counter--;
268263 }
269264 }
@@ -277,7 +272,7 @@
278273 } else if( $i == $n - 1 ) {
279274 $left_slices[$i] = $opening . $left_slices[$i];
280275 } else if( $counter != 0 ) {
281 - $left_slices[$i+1] = $left_slices[$i] . $left_slices[$i+1];
 276+ $left_slices[$i + 1] = $left_slices[$i] . $left_slices[$i+1];
282277 $left_slices[$i] = '';
283278 }
284279 }
Property changes on: branches/REL1_17/extensions/DoubleWiki
___________________________________________________________________
Added: svn:mergeinfo
285280 Merged /trunk/extensions/DoubleWiki:r81672

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81672Remove unused $bits = preg_split( $this->tags, $left_slices[$i] );...reedy00:58, 8 February 2011

Status & tagging log