r81952 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81951‎ | r81952 | r81953 >
Date:10:11, 11 February 2011
Author:demon
Status:deferred
Tags:
Comment:
Followup r81950: array_keys() had a purpose: to remove dupes. Use array_unique() so it's nice and clear :)
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
——@@ -346,7 +346,7 @@
347347 foreach ( $metadata['streams'] as $stream ) {
348348 $streamTypes[] = $stream['type'];
349349 }
350 - return $streamTypes;
 350+ return array_unique( $streamTypes );
351351 }
352352
353353 function getShortDesc( $file ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r87926Forwardport r81952 from OggHandler to TimedMediaHandlerhartman19:57, 12 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81950Fix getStreamTypes(): initialized to a string but used as an array. Also remo...demon10:01, 11 February 2011

Status & tagging log