r81931 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81930‎ | r81931 | r81932 >
Date:06:18, 11 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r81930
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/CommunityVoice/Modules/Ratings.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/CommunityVoice/Modules/Ratings.php
@@ -25,7 +25,7 @@
2626 );
2727 $categories = array();
2828 foreach( $result as $row ) {
29 - $categories[] = (string)$row['vot_category'];
 29+ $categories[] = $row->vot_category;
3030 }
3131 return $categories;
3232 }
@@ -41,7 +41,7 @@
4242 );
4343 $titles = array();
4444 foreach ( $result as $row ) {
45 - $titles[] = (string)$row['vot_title'];
 45+ $titles[] = $row->vot_title;
4646 }
4747 return $titles;
4848 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81930Result objects are objects, not arrays. (fixing breakage from Reedy's mass ch...demon06:16, 11 February 2011

Status & tagging log