r81932 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81931‎ | r81932 | r81933 >
Date:06:42, 11 February 2011
Author:dantman
Status:ok (Comments)
Tags:
Comment:
Fix a small bug in SkinLegacy.
Modified paths:
  • /trunk/phase3/includes/SkinLegacy.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinLegacy.php
@@ -107,7 +107,7 @@
108108
109109 if ( !$shove ) {
110110 $s .= "<td class='top' align='left' valign='top' rowspan='{$rows}'>\n" .
111 - $this->logoText() . '</td>';
 111+ $this->getSkin()->logoText() . '</td>';
112112 } elseif ( $left ) {
113113 $s .= $this->getQuickbarCompensator( $rows );
114114 }

Comments

#Comment by Hashar (talk | contribs)   20:44, 25 March 2011

Do we need this to be backported in 1.17?

#Comment by Dantman (talk | contribs)   20:58, 25 March 2011

SkinLegacy refactor is 1.18.

Status & tagging log