r81849 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81848‎ | r81849 | r81850 >
Date:21:25, 9 February 2011
Author:dale
Status:deferred (Comments)
Tags:todo 
Comment:
* Switched to 'ResourceLoaderGetStartupModules' hook base
* Removed old EmbedPlayer and TimedText to make room for new RL1_17 based modules
Modified paths:
  • /trunk/extensions/MwEmbedSupport/MwEmbed.i18n.php (deleted) (history)
  • /trunk/extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport/README (modified) (history)
  • /trunk/extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport/mwEmbedSupport.js (modified) (history)
  • /trunk/extensions/MwEmbedSupport/MwEmbedResourceManager.php (modified) (history)
  • /trunk/extensions/MwEmbedSupport/MwEmbedSupport.i18n.php (added) (history)
  • /trunk/extensions/MwEmbedSupport/MwEmbedSupport.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/EmbedPlayer (deleted) (history)
  • /trunk/extensions/TimedMediaHandler/README (modified) (history)
  • /trunk/extensions/TimedMediaHandler/TimedMediaHandler.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/TimedText (deleted) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/TimedMediaHandler.php
——@@ -28,9 +28,9 @@
2929 $wgExtensionMessagesFiles['TimedMediaHandlerMagic'] = "$timedMediaDir/TimedMediaHandler.i18n.magic.php";
3030 $wgParserOutputHooks['TimedMediaHandler'] = array( 'TimedMediaHandler', 'outputHook' );
3131
32 -// Load all the mwEmbed modules:
33 -MwEmbedResourceManager::registerModulePath( 'extensions/TimedMediaHandler/EmbedPlayer' );
34 -MwEmbedResourceManager::registerModulePath( 'extensions/TimedMediaHandler/TimedText' );
 32+// Load all the MwEmbed modules:
 33+MwEmbedResourceManager::register( 'extensions/TimedMediaHandler/EmbedPlayer' );
 34+MwEmbedResourceManager::register( 'extensions/TimedMediaHandler/TimedText' );
3535
3636
3737 // Setup a hook for iframe=true (will strip the interface and only output the player)
Index: trunk/extensions/TimedMediaHandler/README
——@@ -6,16 +6,17 @@
77 * use embedPlayer mwEmbed javascript module for playback
88
99
10 -== Old oggHandler Readme ==
11 -
12 -This extension provides a media handler for the Ogg container format. When
 10+This extension provides a media handler for the Ogg and WebM container format. When
1311 enabled, a player will be automatically embedded in the image description page,
1412 or any wiki page using the same syntax as for images.
1513
1614 To install this extension, add the following to the end of your LocalSettings.php:
1715
18 - require( "$IP/extensions/OggHandler/OggHandler.php" );
 16+ // TimedMediaHandler is dependent on mwEmbedSupport
 17+ require( "$IP/extensions/
1918
 19+ require( "$IP/extensions/TimedMediaHandler/TimedMediaHandler.php" );
 20+
2021 oggThumb
2122 ------
2223
Index: trunk/extensions/MwEmbedSupport/MwEmbed.i18n.php
——@@ -1,256 +0,0 @@
2 -<?php
3 -/**
4 - * Internationalisation for MwEmbed extension
5 - *
6 - * @file
7 - * @ingroup Extensions
8 - */
9 -
10 -$messages = array();
11 -
12 -/** English
13 - * @author Michael Dale
14 - */
15 -$messages['en'] = array(
16 - /* Editing Preference Categories */
17 - 'mwembed-desc' => 'Provides support for mwEmbed modules and extensions',
18 -);
19 -
20 -/** Afrikaans (Afrikaans)
21 - * @author Naudefj
22 - */
23 -$messages['af'] = array(
24 - 'mwembed-desc' => 'Bied ondersteuning vir mwEmbed-modules en -uitbreidings',
25 -);
26 -
27 -/** Belarusian (Taraškievica orthography) (‪Беларуская (тарашкевіца)‬)
28 - * @author Jim-by
29 - */
30 -$messages['be-tarask'] = array(
31 - 'mwembed-desc' => 'Пашырэньне падтрымкі для модуляў і пашырэньняў mwEmbed',
32 -);
33 -
34 -/** Bengali (বাংলা)
35 - * @author Bellayet
36 - */
37 -$messages['bn'] = array(
38 - 'mwembed-desc' => 'mwEmbed মডিউল এবং এক্সটেনশন সমর্থন প্রদান করে',
39 -);
40 -
41 -/** Breton (Brezhoneg)
42 - * @author Fulup
43 - */
44 -$messages['br'] = array(
45 - 'mwembed-desc' => 'Pourvezañ a ra ur skor evit modulennoù hag astennoù mwEmbed',
46 -);
47 -
48 -/** Bosnian (Bosanski)
49 - * @author CERminator
50 - */
51 -$messages['bs'] = array(
52 - 'mwembed-desc' => 'Omogućava podršku za mwEmbed module i proširenja',
53 -);
54 -
55 -/** Catalan (Català)
56 - * @author Toniher
57 - */
58 -$messages['ca'] = array(
59 - 'mwembed-desc' => "Proporciona assistència per a mòduls i extensions de l'mwEmbed.",
60 -);
61 -
62 -/** Czech (Česky)
63 - * @author Mormegil
64 - */
65 -$messages['cs'] = array(
66 - 'mwembed-desc' => 'Poskytuje podporu pro moduly a rozšíření mwEmbed',
67 -);
68 -
69 -/** German (Deutsch)
70 - * @author Kghbln
71 - */
72 -$messages['de'] = array(
73 - 'mwembed-desc' => 'Ermöglicht die Nutzung von Modulen und Erweiterungen, die „mwEmbed“ benötigen',
74 -);
75 -
76 -/** Lower Sorbian (Dolnoserbski)
77 - * @author Michawiki
78 - */
79 -$messages['dsb'] = array(
80 - 'mwembed-desc' => 'Dawa pódpěru za module a rozšyrjenja za mwEmbed',
81 -);
82 -
83 -/** Greek (Ελληνικά)
84 - * @author Evropi
85 - */
86 -$messages['el'] = array(
87 - 'mwembed-desc' => 'Παρέχει υποστήριξη για τις μονάδες και επεκτάσεις του mwEmbed',
88 -);
89 -
90 -/** Spanish (Español)
91 - * @author Locos epraix
92 - */
93 -$messages['es'] = array(
94 - 'mwembed-desc' => 'Proporciona soporte para módulos y extensiones mwEmbed',
95 -);
96 -
97 -/** French (Français)
98 - * @author Peter17
99 - */
100 -$messages['fr'] = array(
101 - 'mwembed-desc' => 'L’extension MwEmbed fournit un support pour les modules et extensions mwEmbed',
102 -);
103 -
104 -/** Galician (Galego)
105 - * @author Toliño
106 - */
107 -$messages['gl'] = array(
108 - 'mwembed-desc' => 'Ofrece soporte para módulos e extensións mwEmbed',
109 -);
110 -
111 -/** Swiss German (Alemannisch)
112 - * @author Als-Holder
113 - */
114 -$messages['gsw'] = array(
115 - 'mwembed-desc' => 'Unterstitzig fir d Nutzig vu „mwEmbed“-Module un -Erwyterige',
116 -);
117 -
118 -/** Hebrew (עברית)
119 - * @author YaronSh
120 - */
121 -$messages['he'] = array(
122 - 'mwembed-desc' => 'אספקת תמיכה במודולים והרחבות של mwEmbed',
123 -);
124 -
125 -/** Upper Sorbian (Hornjoserbsce)
126 - * @author Michawiki
127 - */
128 -$messages['hsb'] = array(
129 - 'mwembed-desc' => 'Skići podpěru za module a rozšěrjenja mwEmbed',
130 -);
131 -
132 -/** Hungarian (Magyar)
133 - * @author BáthoryPéter
134 - */
135 -$messages['hu'] = array(
136 - 'mwembed-desc' => 'Támogatást nyújt az „mwEmbed“ modulokhoz és bővítményekhez',
137 -);
138 -
139 -/** Interlingua (Interlingua)
140 - * @author McDutchie
141 - */
142 -$messages['ia'] = array(
143 - 'mwembed-desc' => 'Le extension MwEmbed forni supporto pro modulos e extensiones mwEmbed',
144 -);
145 -
146 -/** Indonesian (Bahasa Indonesia)
147 - * @author IvanLanin
148 - */
149 -$messages['id'] = array(
150 - 'mwembed-desc' => 'Menyediakan dukungan untuk modul dan ekstensi mwEmbed',
151 -);
152 -
153 -/** Japanese (日本語)
154 - * @author 青子守歌
155 - */
156 -$messages['ja'] = array(
157 - 'mwembed-desc' => 'mwEmbed拡張機能は、mwEmbedモジュールと拡張機能のサポートを提供します',
158 -);
159 -
160 -/** Luxembourgish (Lëtzebuergesch)
161 - * @author Robby
162 - */
163 -$messages['lb'] = array(
164 - 'mwembed-desc' => 'Erméiglecht d\'Benotze vu Moduler an Erweiderungen, déi "mwEmbed" brauchen',
165 -);
166 -
167 -/** Macedonian (Македонски)
168 - * @author Bjankuloski06
169 - */
170 -$messages['mk'] = array(
171 - 'mwembed-desc' => 'Додатокот MwEmbed дава поддршка за mwEmbed-модули и додатоци',
172 -);
173 -
174 -/** Dutch (Nederlands)
175 - * @author Siebrand
176 - */
177 -$messages['nl'] = array(
178 - 'mwembed-desc' => 'MwEmbed biedt ondersteuning voor module en uitbreidingen van mwEmbed',
179 -);
180 -
181 -/** Norwegian (bokmål)‬ (‪Norsk (bokmål)‬)
182 - * @author Nghtwlkr
183 - */
184 -$messages['no'] = array(
185 - 'mwembed-desc' => 'Gir støtte for mwEmbed-moduler og -utvidelser',
186 -);
187 -
188 -/** Polish (Polski)
189 - * @author Sp5uhe
190 - */
191 -$messages['pl'] = array(
192 - 'mwembed-desc' => 'Zapewnia wsparcie dla modułów i rozszerzeń mwEmbed',
193 -);
194 -
195 -/** Piedmontese (Piemontèis)
196 - * @author Borichèt
197 - */
198 -$messages['pms'] = array(
199 - 'mwembed-desc' => "A manten ij mòduj e j'estension mwEmbed",
200 -);
201 -
202 -/** Portuguese (Português)
203 - * @author Waldir
204 - */
205 -$messages['pt'] = array(
206 - 'mwembed-desc' => 'Fornece suporte para módulos e extensões mwEmbed',
207 -);
208 -
209 -/** Brazilian Portuguese (Português do Brasil)
210 - * @author Giro720
211 - */
212 -$messages['pt-br'] = array(
213 - 'mwembed-desc' => 'Fornece suporte para módulos e extensões mwEmbed',
214 -);
215 -
216 -/** Tarandíne (Tarandíne)
217 - * @author Joetaras
218 - */
219 -$messages['roa-tara'] = array(
220 - 'mwembed-desc' => 'Dè supporte pe le module mwEmbed e le estenziune sue',
221 -);
222 -
223 -/** Russian (Русский)
224 - * @author Александр Сигачёв
225 - */
226 -$messages['ru'] = array(
227 - 'mwembed-desc' => 'Расширение MwEmbed обеспечивает поддержку модулей mwEmbed',
228 -);
229 -
230 -/** Swedish (Svenska)
231 - * @author Ainali
232 - */
233 -$messages['sv'] = array(
234 - 'mwembed-desc' => 'Ger stöd för mwEmbed moduler och tillägg',
235 -);
236 -
237 -/** Tagalog (Tagalog)
238 - * @author AnakngAraw
239 - */
240 -$messages['tl'] = array(
241 - 'mwembed-desc' => 'Nagbibigay ng suporta para sa mga modulo at mga dugtong na mwEmbed',
242 -);
243 -
244 -/** Ukrainian (Українська)
245 - * @author Тест
246 - */
247 -$messages['uk'] = array(
248 - 'mwembed-desc' => 'Забезпечує підтримку модулів та розширень mwEmbed',
249 -);
250 -
251 -/** Traditional Chinese (‪中文(繁體)‬)
252 - * @author Mark85296341
253 - */
254 -$messages['zh-hant'] = array(
255 - 'mwembed-desc' => '提供支援 mwEmbed 的模塊及擴充套件',
256 -);
257 -
Index: trunk/extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport/README
——@@ -1,3 +1,3 @@
22 This is the mwEmbed Support module it supplies common functionality that other mwEmbed modules depend on.
33
4 -Modules can express the dependency as 'mwembed.support'
\ No newline at end of file
 4+Modules can express the dependency as 'mwEmbedSupport'
\ No newline at end of file
Index: trunk/extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport/mwEmbedSupport.js
——@@ -3,7 +3,7 @@
44 'video audio source track'.replace(/\w+/g,function( n ){ document.createElement( n ) } );
55
66 /**
7 - * mwEmbedSupport includes shared mwEmbed utilities that either
 7+ * MwEmbedSupport includes shared mwEmbed utilities that either
88 * wrap core mediawiki functionality or support legacy mwEmbed module code
99 *
1010 * @license
Index: trunk/extensions/MwEmbedSupport/MwEmbedResourceManager.php
——@@ -85,24 +85,25 @@
8686 * Adds any mwEmbedResources to the ResourceLoader
8787 */
8888 public static function registerModules( &$resourceLoader ) {
89 - global $IP;
 89+ global $IP, $wgStandAloneResourceLoaderMode;
9090 // Register all the resources with the resource loader
9191 foreach( self::$moduleSet as $path => $modules ) {
92 - foreach ( $modules as $name => $resources ) {
93 - $resourceLoader->register(
94 - // Resource loader expects trailing slash:
95 - $name, new MwEmbedResourceLoaderFileModule( $resources, "$IP/$path", $path)
96 - );
 92+ foreach ( $modules as $name => $resources ) {
 93+ // Register the resource with MwEmbed extended class if in standAlone resource loader mode:
 94+ if( $wgStandAloneResourceLoaderMode === true ){
 95+ $resourceLoader->register(
 96+ // Resource loader expects trailing slash:
 97+ $name, new MwEmbedResourceLoaderFileModule( $resources, "$IP/$path", $path)
 98+ );
 99+ } else {
 100+ $resourceLoader->register(
 101+ // Resource loader expects trailing slash:
 102+ $name, new ResourceLoaderFileModule( $resources, "$IP/$path", $path)
 103+ );
 104+ }
97105 }
98106 }
99107 // Continue module processing
100108 return true;
101109 }
102 -
103 - // Add the mwEmbed module to the page:
104 - public static function addMwEmbedModule( &$out, &$sk ){
105 - // Add the mwEmbed module to the output
106 - $out->addModules( 'MwEmbedSupport' );
107 - return true;
108 - }
109110 }
\ No newline at end of file
Index: trunk/extensions/MwEmbedSupport/MwEmbedSupport.i18n.php
——@@ -0,0 +1,256 @@
 2+<?php
 3+/**
 4+ * Internationalisation for MwEmbed extension
 5+ *
 6+ * @file
 7+ * @ingroup Extensions
 8+ */
 9+
 10+$messages = array();
 11+
 12+/** English
 13+ * @author Michael Dale
 14+ */
 15+$messages['en'] = array(
 16+ /* Editing Preference Categories */
 17+ 'mwembed-desc' => 'Provides support for mwEmbed modules and extensions',
 18+);
 19+
 20+/** Afrikaans (Afrikaans)
 21+ * @author Naudefj
 22+ */
 23+$messages['af'] = array(
 24+ 'mwembed-desc' => 'Bied ondersteuning vir mwEmbed-modules en -uitbreidings',
 25+);
 26+
 27+/** Belarusian (Taraškievica orthography) (‪Беларуская (тарашкевіца)‬)
 28+ * @author Jim-by
 29+ */
 30+$messages['be-tarask'] = array(
 31+ 'mwembed-desc' => 'Пашырэньне падтрымкі для модуляў і пашырэньняў mwEmbed',
 32+);
 33+
 34+/** Bengali (বাংলা)
 35+ * @author Bellayet
 36+ */
 37+$messages['bn'] = array(
 38+ 'mwembed-desc' => 'mwEmbed মডিউল এবং এক্সটেনশন সমর্থন প্রদান করে',
 39+);
 40+
 41+/** Breton (Brezhoneg)
 42+ * @author Fulup
 43+ */
 44+$messages['br'] = array(
 45+ 'mwembed-desc' => 'Pourvezañ a ra ur skor evit modulennoù hag astennoù mwEmbed',
 46+);
 47+
 48+/** Bosnian (Bosanski)
 49+ * @author CERminator
 50+ */
 51+$messages['bs'] = array(
 52+ 'mwembed-desc' => 'Omogućava podršku za mwEmbed module i proširenja',
 53+);
 54+
 55+/** Catalan (Català)
 56+ * @author Toniher
 57+ */
 58+$messages['ca'] = array(
 59+ 'mwembed-desc' => "Proporciona assistència per a mòduls i extensions de l'mwEmbed.",
 60+);
 61+
 62+/** Czech (Česky)
 63+ * @author Mormegil
 64+ */
 65+$messages['cs'] = array(
 66+ 'mwembed-desc' => 'Poskytuje podporu pro moduly a rozšíření mwEmbed',
 67+);
 68+
 69+/** German (Deutsch)
 70+ * @author Kghbln
 71+ */
 72+$messages['de'] = array(
 73+ 'mwembed-desc' => 'Ermöglicht die Nutzung von Modulen und Erweiterungen, die „mwEmbed“ benötigen',
 74+);
 75+
 76+/** Lower Sorbian (Dolnoserbski)
 77+ * @author Michawiki
 78+ */
 79+$messages['dsb'] = array(
 80+ 'mwembed-desc' => 'Dawa pódpěru za module a rozšyrjenja za mwEmbed',
 81+);
 82+
 83+/** Greek (Ελληνικά)
 84+ * @author Evropi
 85+ */
 86+$messages['el'] = array(
 87+ 'mwembed-desc' => 'Παρέχει υποστήριξη για τις μονάδες και επεκτάσεις του mwEmbed',
 88+);
 89+
 90+/** Spanish (Español)
 91+ * @author Locos epraix
 92+ */
 93+$messages['es'] = array(
 94+ 'mwembed-desc' => 'Proporciona soporte para módulos y extensiones mwEmbed',
 95+);
 96+
 97+/** French (Français)
 98+ * @author Peter17
 99+ */
 100+$messages['fr'] = array(
 101+ 'mwembed-desc' => 'L’extension MwEmbed fournit un support pour les modules et extensions mwEmbed',
 102+);
 103+
 104+/** Galician (Galego)
 105+ * @author Toliño
 106+ */
 107+$messages['gl'] = array(
 108+ 'mwembed-desc' => 'Ofrece soporte para módulos e extensións mwEmbed',
 109+);
 110+
 111+/** Swiss German (Alemannisch)
 112+ * @author Als-Holder
 113+ */
 114+$messages['gsw'] = array(
 115+ 'mwembed-desc' => 'Unterstitzig fir d Nutzig vu „mwEmbed“-Module un -Erwyterige',
 116+);
 117+
 118+/** Hebrew (עברית)
 119+ * @author YaronSh
 120+ */
 121+$messages['he'] = array(
 122+ 'mwembed-desc' => 'אספקת תמיכה במודולים והרחבות של mwEmbed',
 123+);
 124+
 125+/** Upper Sorbian (Hornjoserbsce)
 126+ * @author Michawiki
 127+ */
 128+$messages['hsb'] = array(
 129+ 'mwembed-desc' => 'Skići podpěru za module a rozšěrjenja mwEmbed',
 130+);
 131+
 132+/** Hungarian (Magyar)
 133+ * @author BáthoryPéter
 134+ */
 135+$messages['hu'] = array(
 136+ 'mwembed-desc' => 'Támogatást nyújt az „mwEmbed“ modulokhoz és bővítményekhez',
 137+);
 138+
 139+/** Interlingua (Interlingua)
 140+ * @author McDutchie
 141+ */
 142+$messages['ia'] = array(
 143+ 'mwembed-desc' => 'Le extension MwEmbed forni supporto pro modulos e extensiones mwEmbed',
 144+);
 145+
 146+/** Indonesian (Bahasa Indonesia)
 147+ * @author IvanLanin
 148+ */
 149+$messages['id'] = array(
 150+ 'mwembed-desc' => 'Menyediakan dukungan untuk modul dan ekstensi mwEmbed',
 151+);
 152+
 153+/** Japanese (日本語)
 154+ * @author 青子守歌
 155+ */
 156+$messages['ja'] = array(
 157+ 'mwembed-desc' => 'mwEmbed拡張機能は、mwEmbedモジュールと拡張機能のサポートを提供します',
 158+);
 159+
 160+/** Luxembourgish (Lëtzebuergesch)
 161+ * @author Robby
 162+ */
 163+$messages['lb'] = array(
 164+ 'mwembed-desc' => 'Erméiglecht d\'Benotze vu Moduler an Erweiderungen, déi "mwEmbed" brauchen',
 165+);
 166+
 167+/** Macedonian (Македонски)
 168+ * @author Bjankuloski06
 169+ */
 170+$messages['mk'] = array(
 171+ 'mwembed-desc' => 'Додатокот MwEmbed дава поддршка за mwEmbed-модули и додатоци',
 172+);
 173+
 174+/** Dutch (Nederlands)
 175+ * @author Siebrand
 176+ */
 177+$messages['nl'] = array(
 178+ 'mwembed-desc' => 'MwEmbed biedt ondersteuning voor module en uitbreidingen van mwEmbed',
 179+);
 180+
 181+/** Norwegian (bokmål)‬ (‪Norsk (bokmål)‬)
 182+ * @author Nghtwlkr
 183+ */
 184+$messages['no'] = array(
 185+ 'mwembed-desc' => 'Gir støtte for mwEmbed-moduler og -utvidelser',
 186+);
 187+
 188+/** Polish (Polski)
 189+ * @author Sp5uhe
 190+ */
 191+$messages['pl'] = array(
 192+ 'mwembed-desc' => 'Zapewnia wsparcie dla modułów i rozszerzeń mwEmbed',
 193+);
 194+
 195+/** Piedmontese (Piemontèis)
 196+ * @author Borichèt
 197+ */
 198+$messages['pms'] = array(
 199+ 'mwembed-desc' => "A manten ij mòduj e j'estension mwEmbed",
 200+);
 201+
 202+/** Portuguese (Português)
 203+ * @author Waldir
 204+ */
 205+$messages['pt'] = array(
 206+ 'mwembed-desc' => 'Fornece suporte para módulos e extensões mwEmbed',
 207+);
 208+
 209+/** Brazilian Portuguese (Português do Brasil)
 210+ * @author Giro720
 211+ */
 212+$messages['pt-br'] = array(
 213+ 'mwembed-desc' => 'Fornece suporte para módulos e extensões mwEmbed',
 214+);
 215+
 216+/** Tarandíne (Tarandíne)
 217+ * @author Joetaras
 218+ */
 219+$messages['roa-tara'] = array(
 220+ 'mwembed-desc' => 'Dè supporte pe le module mwEmbed e le estenziune sue',
 221+);
 222+
 223+/** Russian (Русский)
 224+ * @author Александр Сигачёв
 225+ */
 226+$messages['ru'] = array(
 227+ 'mwembed-desc' => 'Расширение MwEmbed обеспечивает поддержку модулей mwEmbed',
 228+);
 229+
 230+/** Swedish (Svenska)
 231+ * @author Ainali
 232+ */
 233+$messages['sv'] = array(
 234+ 'mwembed-desc' => 'Ger stöd för mwEmbed moduler och tillägg',
 235+);
 236+
 237+/** Tagalog (Tagalog)
 238+ * @author AnakngAraw
 239+ */
 240+$messages['tl'] = array(
 241+ 'mwembed-desc' => 'Nagbibigay ng suporta para sa mga modulo at mga dugtong na mwEmbed',
 242+);
 243+
 244+/** Ukrainian (Українська)
 245+ * @author Тест
 246+ */
 247+$messages['uk'] = array(
 248+ 'mwembed-desc' => 'Забезпечує підтримку модулів та розширень mwEmbed',
 249+);
 250+
 251+/** Traditional Chinese (‪中文(繁體)‬)
 252+ * @author Mark85296341
 253+ */
 254+$messages['zh-hant'] = array(
 255+ 'mwembed-desc' => '提供支援 mwEmbed 的模塊及擴充套件',
 256+);
 257+
Property changes on: trunk/extensions/MwEmbedSupport/MwEmbedSupport.i18n.php
___________________________________________________________________
Added: svn:eol-style
1258 + native
Index: trunk/extensions/MwEmbedSupport/MwEmbedSupport.php
——@@ -13,8 +13,11 @@
1414
1515 /* Configuration */
1616
 17+// When used as an extension we are not in StandAloneResourceLoaderMode:
 18+$wgStandAloneResourceLoaderMode = false;
 19+
 20+
1721 /* Setup */
18 -
1922 $wgExtensionCredits['other'][] = array(
2023 'path' => __FILE__,
2124 'name' => 'MwEmbedSupport',
——@@ -29,9 +32,11 @@
3033
3134 // Add Global MwEmbed Registration hook
3235 $wgHooks['ResourceLoaderRegisterModules'][] = 'MwEmbedResourceManager::registerModules';
 36+
3337 // Add MwEmbed module configuration
3438 $wgHooks['ResourceLoaderGetConfigVars'][] = 'MwEmbedResourceManager::registerConfigVars';
3539
 40+/* MwEmbed Module Registration */
3641
3742 // Register the core MwEmbed Support Module:
3843 MwEmbedResourceManager::register( 'extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport' );
——@@ -39,3 +44,10 @@
4045 // Register the MwEmbed 'mediaWiki' Module:
4146 MwEmbedResourceManager::register( 'extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport' );
4247
 48+// Add MwEmbedSupport to Startup:
 49+function MwUpdateStartupModules( &$modules ){
 50+ array_push($modules, 'jquery.triggerQueueCallback', 'jquery.mwEmbedUtil', 'mwEmbedStartup' );
 51+ return true;
 52+}
 53+$wgHooks['ResourceLoaderGetStartupModules'][] = 'MwUpdateStartupModules';
 54+

Follow-up revisions

RevisionCommit summaryAuthorDate
r81876Follow-up r81849, r81857, r81858, r81860 for Translatewikiraymond07:40, 10 February 2011

Comments

#Comment by Reedy (talk | contribs)   14:13, 16 February 2012

Putting fixme here for ease

MwEmbedResourceLoaderFileModule isn't defined, but is used

Missing svn add somewhere?

#Comment by Mdale (talk | contribs)   20:05, 16 February 2012

Yea its only used in wgStandAloneResourceLoaderMode == true, mode. The stand alone mode defines MwEmbedResourceLoaderFileModule. The stand alone mode does not apply to the extensions usage. In order for the player library to work indepentently of a full mediaWiki install some classes have to be extended or replaced.

The stand alone code is in a branch within the mediaWiki svn.

#Comment by MarkAHershberger (talk | contribs)   01:13, 17 February 2012

converting from FIXME status to TODO tag

#Comment by Mdale (talk | contribs)   21:22, 21 February 2012

not sure what the TODO is. The class is defined in a mode that does not apply to extension based usage of the file.

Status & tagging log