r81806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81805‎ | r81806 | r81807 >
Date:04:12, 9 February 2011
Author:wikibhasha.msr
Status:ok (Comments)
Tags:
Comment:
Update to the bug #27220 - commented the HTML snippet add/edit code. finding a right alternative
Modified paths:
  • /trunk/extensions/WikiBhasha/src/js/core/paneManagement.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiBhasha/src/js/core/paneManagement.js
@@ -185,6 +185,10 @@
186186 // get the text from the wikipedia edit text area.
187187 var composedContent = new String(wbPublishDisplayPane.getWikiTextareaElement().val());
188188
 189+ /*
 190+ # the below code is to add an HTMl comment to the Wikipedia article edit box.
 191+ # the HTML comment is used to track the usage of the tool and this will be replaced with a better implementation soon.
 192+
189193 // get the version number which says number of times this document was edited using wikiBhasha
190194 if (wbGlobalSettings.wbEditRevisionCount === null) {
191195 // getEditVersion returns the version number if exists, otherwise it returns null
@@ -204,6 +208,7 @@
205209 snippet = "<!-- WikiBhasha v=" + (wbGlobalSettings.wbEditRevisionCount + 1) + " time=" + wbUIHelper.getTimeStamp() + "-->";
206210 composedContent = composedContent.replace(regEx, snippet);
207211 }
 212+ */
208213
209214 // call the method to check and insert the interwiki link
210215 composedContent = wbPublishDisplayPane.insertInterWikiLink(composedContent);

Comments

#Comment by Siebrand (talk | contribs)   09:02, 9 February 2011

Please use "bug 123456" in your commit summary to refer to bug IDs in bugzilla.wikimedia.org. We usually do not add the "#", although it does not appear to make a difference to the parser of CodeReview apparently.

Status & tagging log