r81779 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81778‎ | r81779 | r81780 >
Date:22:03, 8 February 2011
Author:platonides
Status:reverted (Comments)
Tags:
Comment:
$IP marked as global again in line 1208, function includeExtensions
Unused global $wgHooks in function includeExtensions line 1208
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
——@@ -1205,7 +1205,6 @@
12061206 * but we're not opening that can of worms
12071207 * @see https://bugzilla.wikimedia.org/show_bug.cgi?id=26857
12081208 */
1209 - global $wgHooks, $IP;
12101209 require( "$IP/includes/DefaultSettings.php" );
12111210
12121211 foreach( $exts as $e ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r82680Partial revert r81779, $wgHooks is needed. Also add $wgAutoloadClassesdemon16:48, 23 February 2011

Comments

#Comment by 😂 (talk | contribs)   16:48, 23 February 2011

$wgHooks is needed for LoadExtensionSchemaUpdates usage, read the comment right above it. Also needs use $wgAutoloadClasses. Fixup in r82680.

Redeclaring $IP was wrong, you're correct.

Status & tagging log