r81749 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81748‎ | r81749 | r81750 >
Date:15:21, 8 February 2011
Author:platonides
Status:ok
Tags:
Comment:
No need to break the API calling the private clearState() when there's a clearState parameter which you were passing as false.
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -2136,17 +2136,12 @@
21372137
21382138 $title = $wgTitle ? $wgTitle : $user->getUserPage();
21392139
2140 - // Parser gets antsy about parser options here if it hasn't parsed anything before.
2141 - $wgParser->mOptions = new ParserOptions;
2142 - $wgParser->clearState();
2143 - $wgParser->setTitle( $title );
2144 -
21452140 $sig = $wgParser->preSaveTransform(
21462141 $sig,
21472142 $title,
21482143 $user,
2149 - $wgParser->mOptions,
2150 - false
 2144+ new ParserOptions,
 2145+ true
21512146 );
21522147
21532148 return $sig;

Follow-up revisions

RevisionCommit summaryAuthorDate
r81750Merge r81746 & r81749platonides15:25, 8 February 2011

Status & tagging log