r81679 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81678‎ | r81679 | r81680 >
Date:02:02, 8 February 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 27230) Alignment fix for Vector watch tab icon spinner in IE 7

The CSS for the loading tab had:
background-position: center 60%;

The 'center' apparently worked for other browsers, but in IE7 it was getting a bit off, and threw the image over a few pixels.
'center' keyword here is allegedly equivalent to 50% which I also tried, but with the same results.

Instead, using the same fixed position that we specify for the regular rest-state icon works:

background-position: 5px 60%;

Resulting looks ok for me in:
* IE 6 / XP
* IE 7 / XP (fixes regression)
* IE 8 / XP
* Firefox 4b10 / Linux

Shouldn't hurt anything else.
Modified paths:
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/screen.css
@@ -1173,7 +1173,7 @@
11741174 #ca-watch.icon a.loading {
11751175 /* @embed */
11761176 background-image: url(images/watch-icon-loading.gif);
1177 - background-position: center 60%;
 1177+ background-position: 5px 60%;
11781178 }
11791179 #ca-unwatch.icon a span,
11801180 #ca-watch.icon a span {

Follow-up revisions

RevisionCommit summaryAuthorDate
r81680MFT: r81679brion02:25, 8 February 2011
r81681MFT r81679 via REL1_17 r81680.brion02:26, 8 February 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   02:03, 8 February 2011

Needs merge for 1.17

#Comment by Brion VIBBER (talk | contribs)   02:27, 8 February 2011

Merged per consensus in #wikimedia-dev

Status & tagging log