r81571 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r81570‎ \| r81571 \| r81572 >
Date:	20:28, 5 February 2011
Author:	dantman
Status:	ok (Comments)
Tags:
Comment:	Html::expandAttributes( array( 'foo' => null ) ); ' foo=""' -> '' Outputting ' foo="" on `foo = null` promotes the writing of overly verbose code to avoid it, and ugly methods like our old Linker::getLinkAttributesInternal, both of which are completely counter to the purpose of Html::.
Modified paths:	/trunk/phase3/includes/Html.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Html.php
—	—	@@ -352,7 +352,7 @@
353	353	$ret = '';
354	354	$attribs = (array)$attribs;
355	355	foreach ( $attribs as $key => $value ) {
356		~~- if ( $value === false ) {~~
	356	+ if ( $value === false \|\| is_null( $value ) ) {
357	357	continue;
358	358	}
359	359

Revision	Commit summary	Author	Date
r91419	tests for Html::testExpandAttributes()...	hashar	19:51, 4 July 2011

#Comment by Hashar (talk | contribs) 08:11, 3 June 2011

Might use some PHPUnit tests cases -> +'write-test'

#Comment by Hashar (talk | contribs) 19:52, 4 July 2011

Some tests added with r91419

#Comment by Hashar (talk | contribs) 09:43, 24 October 2011

removing tag 'needs-php-test' since I have added tests.

09:43, 24 October 2011 Hashar (talk | contribs) changed the tags for r81571 [removed: needs-php-test]
19:52, 4 July 2011 Hashar (talk | contribs) changed the status of r81571 [removed: new added: ok]
00:44, 15 June 2011 Krinkle (talk | contribs) changed the tags for r81571 [removed: write-test added: needs-php-test]
08:11, 3 June 2011 Hashar (talk | contribs) changed the tags for r81571 [added: write-test]