r81478 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81477‎ | r81478 | r81479 >
Date:19:27, 3 February 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Fixed comparison in addToChangeListLine()
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
——@@ -1690,7 +1690,7 @@
16911691 $css = 'flaggedrevs-unreviewed';
16921692 }
16931693 // page is reviewed and has pending edits (use timestamps; bug 15515)
1694 - } elseif ( $rc->mAttribs['rc_timestamp'] > $rc->mAttribs['fp_pending_since'] ) {
 1694+ } elseif ( $rc->mAttribs['rc_timestamp'] >= $rc->mAttribs['fp_pending_since'] ) {
16951695 $rlink = $list->skin->link(
16961696 $title,
16971697 wfMsgHtml( 'revreview-reviewlink' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r81682MFT r81478, r81478demon02:26, 8 February 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   03:38, 4 February 2011

Just to note -- following r81479 changes this same line further, fixing bugzilla:27129.

This rev here appears to fix so you do see the link to diff & sighting/review request for the first new draft edit (should have rc_timestamp matching fp_pending_since, if comments in DB def are correct :) This is less dramatic-looking than the next fix.

#Comment by Aaron Schulz (talk | contribs)   03:50, 4 February 2011

Yep :)

Status & tagging log