r81393 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81392‎ | r81393 | r81394 >
Date:15:30, 2 February 2011
Author:btongminh
Status:ok
Tags:
Comment:
Remove the $request parameter fro SpecialUploadStash::__construct(). This parameter was in SpecialUpload::__construct because it used to be the only way to talk to the upload backend in the pre-1.16 era. Not needed for SpecialUploadStash.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUploadStash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUploadStash.php
@@ -36,7 +36,7 @@
3737 // uploading.
3838 const MAX_SERVE_BYTES = 262144; // 256K
3939
40 - public function __construct( $request = null ) {
 40+ public function __construct() {
4141 global $wgRequest;
4242
4343 parent::__construct( 'UploadStash', 'upload' );
@@ -46,7 +46,7 @@
4747 return null;
4848 }
4949
50 - $this->loadRequest( is_null( $request ) ? $wgRequest : $request );
 50+ $this->loadRequest( $wgRequest );
5151 }
5252
5353 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r850001.17wmf1: MFT changes for UploadWizard deployment: r78426, r81393, r81401, r8...catrope08:20, 30 March 2011

Status & tagging log