r81169 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81168‎ | r81169 | r81170 >
Date:22:17, 28 January 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Follow up r81100. Don't hardcode hiddencat quotes, per r80936 CR.
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -1002,7 +1002,7 @@
10031003 $lb->constructSet( 'page', $dbr ),
10041004 __METHOD__,
10051005 array(),
1006 - array( 'page_props' => array( 'LEFT JOIN', "pp_propname='hiddencat' AND pp_page=page_id" ) )
 1006+ array( 'page_props' => array( 'LEFT JOIN', array( 'pp_propname' => 'hiddencat', 'pp_page = page_id' ) )
10071007 );
10081008
10091009 # Add the results to the link cache

Follow-up revisions

RevisionCommit summaryAuthorDate
r81178fixing php Parse error: syntax error from r81169krinkle23:31, 28 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80936Couple more raw SQL to query arraysreedy23:15, 24 January 2011
r81100Followup r81067, use the right syntax for doing a joinoverlordq20:25, 27 January 2011

Comments

#Comment by Krinkle (talk | contribs)   23:27, 28 January 2011 
Parse error: syntax error, unexpected ';' in htdocs/w/includes/OutputPage.php on line 1006

Looks like there's a ) missing. (It's a array level deeper now)
#Comment by Krinkle (talk | contribs)   23:29, 28 January 2011 
Parse error: syntax error, unexpected ';' in htdocs/w/includes/OutputPage.php on line 1006

Looks like there's an ) missing. (It's an array level deeper now)

#Comment by Krinkle (talk | contribs)   23:31, 28 January 2011

Speedy fixed in r81178.

#Comment by Platonides (talk | contribs)   23:47, 28 January 2011

Thanks. I was wondering who produced the E_PARSE... :(

Status & tagging log