r81147 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r81146‎ \| r81147 \| r81148 >
Date:	18:58, 28 January 2011
Author:	tparscal
Status:	resolved (Comments)
Tags:
Comment:	Fixed bug - skin is passed to the page through ResourceLoaderConfigVars now since it's not page specific, so the MakeGlobalVariableScripts hook this extension uses, which depends on reading the $var param for it's skin value, needs to also use ResourceLoaderConfigVars - besides, it's also not page-specific, so it's better to place it there.
Modified paths:	/trunk/extensions/AjaxLogin/AjaxLogin.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AjaxLogin/AjaxLogin.php
—	—	@@ -42,7 +42,7 @@
43	43	// Hook things up
44	44	$wgHooks['BeforePageDisplay'][] = 'AjaxLoginJS';
45	45	$wgHooks['SkinAfterContent'][] = 'GetAjaxLoginForm';
46		~~-$wgHooks['MakeGlobalVariablesScript'][] = 'efAddAjaxLoginVariables';~~
	46	+$wgHooks['ResourceLoaderConfigVars'][] = 'efAddAjaxLoginVariables';
47	47
48	48	/**
49	49	* Adds required JavaScript & CSS files to the HTML output of a page if AjaxLogin is enabled

Revision	Commit summary	Author	Date
r94189	Fix hook name	ialex	19:29, 10 August 2011

#Comment by Aaron Schulz (talk | contribs) 02:05, 15 June 2011

Hrm, I can't find where ResourceLoaderConfigVars fires.

#Comment by Catrope (talk | contribs) 10:23, 15 June 2011

That's because it's ResourceLoaderGetConfigVars

#Comment by 😂 (talk | contribs) 14:44, 31 August 2011

Fixed in r94189.

14:44, 31 August 2011 😂 (talk | contribs) changed the tags for r81147 [removed: nodeploy]
14:44, 31 August 2011 😂 (talk | contribs) changed the status of r81147 [removed: fixme added: resolved]
21:02, 15 August 2011 MarkAHershberger (talk | contribs) changed the tags for r81147 [added: nodeploy]
10:23, 15 June 2011 Catrope (talk | contribs) changed the status of r81147 [removed: new added: fixme]