| Index: trunk/extensions/OpenStackManager/special/SpecialNovaSecurityGroup.php |
| — | — | @@ -488,7 +488,7 @@ |
| 489 | 489 | $group = $this->adminNova->getSecurityGroup( $groupname ); |
| 490 | 490 | if ( $group ) { |
| 491 | 491 | # This isn't a supported function in the API for now. Leave this action out for now |
| 492 | | - $success = $this->userNova->modifySecurityGroup( $groupname, array( 'description' => $description )) ; |
| | 492 | + $success = $this->userNova->modifySecurityGroup( $groupname, array( 'description' => $description )); // FIXME: $description is undefined |
| 493 | 493 | if ( $success ) { |
| 494 | 494 | $out = Html::element( 'p', array(), wfMsg( 'openstackmanager-modifiedgroup' ) ); |
| 495 | 495 | } else { |
| Index: trunk/extensions/OpenStackManager/OpenStackNovaRole.php |
| — | — | @@ -93,6 +93,7 @@ |
| 94 | 94 | return false; |
| 95 | 95 | } |
| 96 | 96 | unset( $members[$index] ); |
| | 97 | + $values = array(); |
| 97 | 98 | $values['member'] = array(); |
| 98 | 99 | foreach ( $members as $member ) { |
| 99 | 100 | $values['member'][] = $member; |
| — | — | @@ -178,6 +179,12 @@ |
| 179 | 180 | return $roles; |
| 180 | 181 | } |
| 181 | 182 | |
| | 183 | + /** |
| | 184 | + * @static |
| | 185 | + * @param $rolename |
| | 186 | + * @param $project OpenStackNovaProject |
| | 187 | + * @return bool |
| | 188 | + */ |
| 182 | 189 | static function createRole( $rolename, $project ) { |
| 183 | 190 | global $wgAuth; |
| 184 | 191 | global $wgOpenStackManagerLDAPUser, $wgOpenStackManagerLDAPUserPassword; |
| Index: trunk/extensions/OpenStackManager/OpenStackNovaProject.php |
| — | — | @@ -196,7 +196,7 @@ |
| 197 | 197 | wfSuppressWarnings(); |
| 198 | 198 | $success = ldap_add( $wgAuth->ldapconn, $projectdn, $project ); |
| 199 | 199 | wfRestoreWarnings(); |
| 200 | | - $project = OpenStackNovaProject( $projectname ); |
| | 200 | + $project = new OpenStackNovaProject( $projectname ); |
| 201 | 201 | if ( $success ) { |
| 202 | 202 | foreach ( self::$rolenames as $rolename ) { |
| 203 | 203 | $role = OpenStackNovaRole::createRole( $rolename, $project ); |