r80928 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80927‎ | r80928 | r80929 >
Date:22:05, 24 January 2011
Author:hartman
Status:ok
Tags:
Comment:
port rtl specific parts of modern RTL css to main.css

In the new auto flipped CSS, the "html > body div#mw_contentholder ul li" specific hacks were breaking layout on other browsers, so removing those.

Follow up to r80776
Modified paths:
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/modern/rtl.css (deleted) (history)

Diff [purge]

Index: trunk/phase3/skins/modern/rtl.css
@@ -1,162 +0,0 @@
2 -body {
3 - direction: rtl;
4 - unicode-bidi: embed;
5 -}
6 -
7 -.editsection {
8 - float: left;
9 - margin-right: 5px;
10 - margin-left: 0; /* bug 9122: undo default LTR */
11 -}
12 -
13 -/* Fix alignment */
14 -.documentByLine,
15 -.portletDetails,
16 -.portletMore {
17 - text-align: left;
18 -}
19 -
20 -div div.thumbcaption {
21 - text-align: right;
22 -}
23 -
24 -div.magnify {
25 - left: auto;
26 - right: 0;
27 -}
28 -
29 -/* Fix margins for non-css2 browsers */
30 -/* top right bottom left */
31 -
32 -dd {
33 - margin-left: 0;
34 - margin-right: 1.6em;
35 -}
36 -.tocindent {
37 - margin-left: 0;
38 - margin-right: 2em;
39 -}
40 -div.tright, div.floatright, table.floatright {
41 - clear: none;
42 -}
43 -div.tleft, div.floatleft, table.floatleft {
44 - clear: left;
45 -}
46 -
47 -/* Fix link icons */
48 -.external, a.feedlink {
49 - padding: 0 !important;
50 - background: none !important;
51 -}
52 -
53 -/* js pref toc */
54 -
55 -#preftoc {
56 - margin-right: 1em;
57 -}
58 -
59 -.errorbox, .successbox, #preftoc li, .prefsection fieldset {
60 - float: right;
61 -}
62 -
63 -.prefsection {
64 - padding-right: 2em;
65 -}
66 -
67 -/* workaround for moz bug, displayed bullets on left side */
68 -
69 -#toc ul {
70 - text-align: right;
71 -}
72 -
73 -#toc ul ul {
74 - margin: 0 2em 0 0;
75 -}
76 -
77 -input#wpSave, input#wpDiff {
78 - margin-right: 0;
79 - margin-left: .33em;
80 -}
81 -
82 -#userlogin {
83 - margin: 0 0 1em 3em;
84 -}
85 -/* Convenience links to edit block, delete and protect reasons */
86 -p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
87 -p.mw-filedelete-editreasons, p.mw-delete-editreasons {
88 - float: left;
89 -}
90 -
91 -.toggle {
92 - margin-left: 0em;
93 - margin-right: 2em;
94 -}
95 -table.filehistory th {
96 - text-align: right;
97 -}
98 -
99 -#mw_contentwrapper {
100 - margin: 0 -15em 0 0;
101 - float: left;
102 -}
103 -
104 -#mw_content {
105 - margin: 0 14em 0 0;
106 - border-left: none;
107 - border-right: solid 1px #bbbbbb;
108 -}
109 -
110 -.portlet ul {
111 - margin: 0 1.5em 0 0;
112 - padding: 0 0 0 0;
113 -}
114 -
115 -.portlet h5 {
116 - padding: 0.1em 1em 0.3em 0;
117 -}
118 -
119 -#p-cactions li {
120 - float: right;
121 -}
122 -
123 -#p-personal li {
124 - float: right;
125 -}
126 -
127 -#p-cactions {
128 - margin: 0 14em 0 0;
129 -}
130 -
131 -#mw_portlets {
132 - border-right: none;
133 - border-left: solid 1px #bbbbbb;
134 -}
135 -
136 -/**
137 - * Lists:
138 - * The following lines don't have a visible effect on non-Gecko browsers
139 - * They fix a problem ith Gecko browsers rendering lists to the right of
140 - * left-floated objects in an RTL layout.
141 - */
142 -html > body div#mw_contentholder ul {
143 - display: table;
144 -}
145 -html > body div#mw_contentholder ul li {
146 - margin-right:10px;
147 -}
148 -html > body div.pBody ul li {
149 - margin-right:4px;
150 -}
151 -html > body div#mw_contentholder ul#filetoc {
152 - display: block;
153 -}
154 -
155 -/* Special:Allpages styling */
156 -td.mw-allpages-nav, p.mw-allpages-nav, td.mw-allpages-alphaindexline {
157 - text-align: left;
158 -}
159 -
160 -/* Special:PrefixIndex styling */
161 -td#mw-prefixindex-nav-form {
162 - text-align: left;
163 -}
Index: trunk/phase3/skins/modern/main.css
@@ -901,3 +901,19 @@
902902 .tipsy {
903903 font-size: 130%;
904904 }
 905+
 906+/**
 907+ * Lists:
 908+ * The following lines don't have a visible effect on non-Gecko browsers
 909+ * They fix a problem ith Gecko browsers rendering lists to the right of
 910+ * left-floated objects in an RTL layout.
 911+ */
 912+/* @noflip */
 913+html > body.rtl div#mw_contentholder ul {
 914+ display: table;
 915+}
 916+
 917+/* @noflip */
 918+html > body.rtl div#mw_contentholder ul#filetoc {
 919+ display: block;
 920+}
\ No newline at end of file

Sign-offs

UserFlagDate
DieBuchetested08:54, 15 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80776Port Modern to resourceloader...hartman22:46, 22 January 2011

Status & tagging log