r80924 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80923‎ | r80924 | r80925 >
Date:21:50, 24 January 2011
Author:hartman
Status:ok (Comments)
Tags:todo 
Comment:
Integrate what was functionally left of common_rtl.css into oldshared.css
Commit the Resourceloader conversion of oldshared.css that I had forgotten to commit

Follow up to r80785
Modified paths:
  • /trunk/phase3/skins/common/common_rtl.css (deleted) (history)
  • /trunk/phase3/skins/common/oldshared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/common_rtl.css
@@ -1,59 +0,0 @@
2 -/*
3 - * This file contains CSS settings common to RTL wikis use the old
4 - * pre-Monobook skins Wikistandard, Nostalgia and CologneBlue
5 - * NOTE: This file is not used in Monobook and Vector!
6 - */
7 -
8 -/* js pref toc */
9 -#preftoc { float: right; }
10 -/* workaround for moz bug, displayed bullets on left side */
11 -#preftoc li { list-style: none; }
12 -#prefcontrol { float: right; }
13 -fieldset.prefsection,
14 -fieldset.operaprefsection {
15 - margin-left: 0;
16 - margin-right: 18em;
17 -}
18 -/* page history */
19 -#pagehistory .history-user {
20 - margin-right: 1.4em;
21 - margin-left: 0.4em;
22 -}
23 -.editsection {
24 - float: left;
25 - margin-right: 5px;
26 -}
27 -div.tright, div.floatright {
28 - clear: none;
29 -}
30 -div.tleft, div.floatleft {
31 - clear: left;
32 -}
33 -/* Convenience links to edit block, delete and protect reasons */
34 -p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
35 -p.mw-filedelete-editreasons, p.mw-delete-editreasons,
36 -p.mw-revdel-editreasons {
37 - float: left;
38 -}
39 -table.filehistory th {
40 - text-align: right;
41 -}
42 -
43 -/**
44 - * Lists:
45 - * The following lines don't have a visible effect on non-Gecko browsers
46 - * They fix a problem ith Gecko browsers rendering lists to the right of
47 - * left-floated objects in an RTL layout.
48 - */
49 -html > body div#article ul {
50 - display: table;
51 -}
52 -html > body div#bodyContent ul#filetoc {
53 - display: block;
54 -}
55 -
56 -/* feed links */
57 -a.feedlink {
58 - background: none !important;
59 - padding-left: 0 !important;
60 -}
Index: trunk/phase3/skins/common/oldshared.css
@@ -30,22 +30,26 @@
3131
3232 #footer { clear: both }
3333 /* images */
 34+/* @noflip */
3435 div.floatright {
3536 float: right;
3637 clear: right;
3738 margin: 0 0 1em 1em;
3839 }
3940
 41+/* @noflip */
4042 div.floatright p {
4143 font-style: italic;
4244 }
4345
 46+/* @noflip */
4447 div.floatleft {
4548 float: left;
4649 clear: left;
4750 margin: 0.3em 0.5em 0.5em 0;
4851 }
4952
 53+/* @noflip */
5054 div.floatleft p {
5155 font-style: italic;
5256 }
@@ -100,11 +104,13 @@
101105 border: none !important;
102106 background: none !important;
103107 }
 108+/* @noflip */
104109 div.tright {
105110 clear: right;
106111 float: right;
107112 border-width: .5em 0 .8em 1.4em;
108113 }
 114+/* @noflip */
109115 div.tleft {
110116 float: left;
111117 clear: left;
@@ -428,8 +434,29 @@
429435 }
430436
431437 body {
 438+ direction: ltr;
 439+ unicode-bidi: embed;
432440 background-color: #ffffec;
433441 }
434442 body.ns-0 {
435443 background-color: white;
436444 }
 445+
 446+/** RTL specific CSS starts here **/
 447+
 448+/**
 449+ * Lists:
 450+ * The following lines don't have a visible effect on non-Gecko browsers
 451+ * They fix a problem ith Gecko browsers rendering lists to the right of
 452+ * left-floated objects in an RTL layout.
 453+ */
 454+/* @noflip */
 455+html > body.rtl div#article ul {
 456+ display: table;
 457+}
 458+/* @noflip */
 459+html > body.rtl div#bodyContent ul#filetoc {
 460+ display: block;
 461+}
 462+
 463+/* RTL specific CSS ends here **/
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r80953fixed typo from r80924krinkle02:13, 25 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80785Port the remaining Skin.php skins standard(classic), Cologneblue and Nostalgia...hartman01:41, 23 January 2011

Comments

#Comment by Krinkle (talk | contribs)   14:00, 28 May 2011

About half of the /* @noflip */ seem redundant. It's only applicable to direction-related style declarations like for example float, text-align..

#Comment by TheDJ (talk | contribs)   14:19, 29 May 2011

Yeah I just did a hurried conversion. Didn't have the time back then to check what parts were actually used.

Status & tagging log