r80914 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r80913‎ | r80914 | r80915 >
Date:20:44, 24 January 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
1.16wmf4: Commit live hack adding profiling to memcached-client.php
Modified paths:
  • /branches/wmf/1.16wmf4/includes/memcached-client.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/includes/memcached-client.php
——@@ -916,7 +916,9 @@
917917 if ( $this->_have_zlib && $this->_compress_enable &&
918918 $this->_compress_threshold && $len >= $this->_compress_threshold )
919919 {
920 - $c_val = gzcompress( $val, 9 );
 920+ wfProfileIn( __METHOD__.'-gzcompress' );
 921+ $c_val = gzcompress( $val, 3 );
 922+ wfProfileOut( __METHOD__.'-gzcompress' );
921923 $c_len = strlen( $c_val );
922924
923925 if ( $c_len < $len * ( 1 - self::COMPRESSION_SAVINGS ) ) {

Comments

#Comment by Reedy (talk | contribs)   21:36, 24 January 2011

I'm guessing most of these changes are getting merged back into trunk at somepoint...?

#Comment by Catrope (talk | contribs)   02:03, 25 January 2011

Yes. I just wanted to get it out of the way for now, I'll go through them tomorrow and figure out what can go in trunk.

Status & tagging log