r80895 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r80894‎ | r80895 | r80896 >
Date:18:45, 24 January 2011
Author:ialex
Status:ok
Tags:
Comment:
Fix for r80864: the $dbname variable was not there only to make pretty debug output, but also to let the connection choose the correct database. This was breaking connections to other databases since they were always using wiki's database.
Modified paths:
  • /trunk/phase3/includes/db/LoadBalancer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/LoadBalancer.php
——@@ -624,7 +624,7 @@
625625 $dbname = $server['dbname'];
626626
627627 if ( $dbNameOverride !== false ) {
628 - $dbname = $dbNameOverride;
 628+ $server['dbname'] = $dbname = $dbNameOverride;
629629 }
630630
631631 # Create object

Follow-up revisions

RevisionCommit summaryAuthorDate
r83414MFT r80864, r80895demon22:41, 6 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80864Followup to r79848 (and really, make it useful...)...demon16:31, 24 January 2011

Status & tagging log