r80616 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80615‎ | r80616 | r80617 >
Date:06:42, 20 January 2011
Author:tstarling
Status:ok
Tags:
Comment:
Revert r70418, r70959: direct use of $_GET is not needed anymore since we no longer use null characters as separators as of r80443.
Modified paths:
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -68,18 +68,15 @@
6969 }
7070
7171 function closeShowCategory() {
72 - global $wgOut;
 72+ global $wgOut, $wgRequest;
7373
7474 $from = $until = array();
7575 foreach ( array( 'page', 'subcat', 'file' ) as $type ) {
76 - # Use $_GET instead of $wgRequest, because the latter helpfully
77 - # normalizes Unicode, which removes nulls. TODO: do something
78 - # smarter than passing nulls in URLs. :/
79 - $from[$type] = isset( $_GET["{$type}from"] ) ? $_GET["{$type}from"] : null;
80 - $until[$type] = isset( $_GET["{$type}until"] ) ? $_GET["{$type}until"] : null;
 76+ $from[$type] = $wgRequest->getVal( "{$type}from" );
 77+ $until[$type] = $wgRequest->getVal( "{$type}until" );
8178 }
8279
83 - $viewer = new $this->mCategoryViewerClass( $this->mTitle, $from, $until, $_GET );
 80+ $viewer = new $this->mCategoryViewerClass( $this->mTitle, $from, $until, $wgRequest->getValues() );
8481 $wgOut->addHTML( $viewer->getHTML() );
8582 }
8683 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r806781.17: MFT category collation changes: r80432, r80443, r80590, r80614, r80615,...catrope03:16, 21 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70418Fix bug in sorting due to $wgRequest eating nulls...simetrical20:50, 3 August 2010
r70959Hacky r70418 makes this global unused.platonides14:34, 12 August 2010
r80443* Introduced a non-dummy collation for $wgCategoryCollation, namely UCA with ...tstarling14:02, 17 January 2011

Status & tagging log