r80612 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80611‎ | r80612 | r80613 >
Date:02:32, 20 January 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
Partial revert r78450: doQuery() and query() are not the same. You can't just swap one for the other without checking what might be using the result
Modified paths:
  • /trunk/phase3/includes/search/SearchPostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/search/SearchPostgres.php
@@ -148,7 +148,7 @@
149149
150150 ## We need a separate query here so gin does not complain about empty searches
151151 $SQL = "SELECT to_tsquery($prefix $searchstring)";
152 - $res = $this->db->query($SQL);
 152+ $res = $this->db->doQuery($SQL);
153153 if (!$res) {
154154 ## TODO: Better output (example to catch: one 'two)
155155 die ("Sorry, that was not a valid search string. Please go back and try again");

Follow-up revisions

RevisionCommit summaryAuthorDate
r92328REL1_18 MFT r79056, r80612, r81499, r87627, r87628, r87630, r87998, r88134, r...reedy22:46, 15 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78450Changed doQuery() -> query()aaron20:59, 15 December 2010

Comments

#Comment by Aaron Schulz (talk | contribs)   02:12, 22 January 2011

Hoping these get replaced sometime though.

#Comment by 😂 (talk | contribs)   02:25, 22 January 2011

That would be nice :)

#Comment by Aaron Schulz (talk | contribs)   02:31, 22 January 2011

Not as nice is never seeing pg_fetch_result() crap again :D

#Comment by Siebrand (talk | contribs)   22:16, 11 July 2011

Tagged 1.18 because r78450 is tagged 1.18.

Status & tagging log