r80350 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80349‎ | r80350 | r80351 >
Date:23:20, 14 January 2011
Author:reedy
Status:ok
Tags:
Comment:
More query reorganisation, in an attempt to be index friendly
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryCategoryMembers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryCategoryMembers.php
@@ -93,9 +93,7 @@
9494
9595 $this->addTables( array( 'page', 'categorylinks' ) ); // must be in this order for 'USE INDEX'
9696
97 - $this->setContinuation( $params['continue'], $params['dir'] );
9897 $this->addWhereFld( 'cl_to', $categoryTitle->getDBkey() );
99 -
10098 $this->addWhereFld( 'cl_type', $params['type'] );
10199
102100 // Scanning large datasets for rare categories sucks, and I already told
@@ -129,6 +127,8 @@
130128
131129 $this->addWhere( 'cl_from=page_id' );
132130
 131+ $this->setContinuation( $params['continue'], $params['dir'] );
 132+
133133 $limit = $params['limit'];
134134 $this->addOption( 'LIMIT', $limit + 1 );
135135

Follow-up revisions

RevisionCommit summaryAuthorDate
r80351Bleh, didn't press save again (r80350)reedy23:24, 14 January 2011
r807221.17: MFT r80324, r80326, r80328, r80339, r80350, r80351, r80355, r80358, r80...catrope23:00, 21 January 2011

Status & tagging log