r80272 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80271‎ | r80272 | r80273 >
Date:15:08, 14 January 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
use require( RUN_MAINTENANCE_IF_MAIN ) as per r80205

fix review on r80269
Modified paths:
  • /trunk/phase3/maintenance/benchmarks/bench_if_switch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/benchmarks/bench_if_switch.php
@@ -85,4 +85,4 @@
8686 }
8787
8888 $maintClass = 'bench_if_switch';
89 -require_once( DO_MAINTENANCE );
 89+require_once( RUN_MAINTENANCE_IF_MAIN );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80205Fix concern raised by Brion in r74108 (but has really existed since the maint...demon22:58, 13 January 2011
r80269lame benchmark of if/elseif/else versus switch/case/default...hashar14:46, 14 January 2011

Comments

#Comment by Catrope (talk | contribs)   02:07, 19 January 2011

Untagged 1.17, this benchmark isn't in REL1_17.

Status & tagging log