r80238 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80237‎ | r80238 | r80239 >
Date:07:05, 14 January 2011
Author:freakolowsky
Status:ok (Comments)
Tags:
Comment:
* changed variable list as per comment on r79954 left only wgDBtype
* all other variables get set trough ->getGlobalNames
* could somone test this on mysql, postgres and sqlite ... it should work, but to be sure
Modified paths:
  • /trunk/phase3/includes/installer/OracleInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/OracleInstaller.php
@@ -15,7 +15,7 @@
1616 class OracleInstaller extends DatabaseInstaller {
1717
1818 protected $globalNames = array(
19 - 'wgDBport',
 19+ 'wgDBserver',
2020 'wgDBname',
2121 'wgDBuser',
2222 'wgDBpassword',
Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -300,7 +300,7 @@
301301 }
302302
303303 // Set the relevant variables from LocalSettings.php
304 - $requiredVars = array( 'wgDBtype', 'wgDBuser', 'wgDBpassword', 'wgDBname', 'wgDBserver' );
 304+ $requiredVars = array( 'wgDBtype' );
305305 $status = $this->importVariables( $requiredVars , $vars );
306306 $installer = $this->parent->getDBInstaller();
307307 $status->merge( $this->importVariables( $installer->getGlobalNames(), $vars ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r81182MFT a bunch of installer fixes. r80238, r80128, r80124, r80083, r80080, r800...demon01:59, 29 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79954* fixed oracle code for updater (corrected not null BLOB field adding) ...freakolowsky20:11, 10 January 2011

Comments

#Comment by 😂 (talk | contribs)   19:37, 18 January 2011

Does Oracle not need $wgDBport anymore? Never did?

Change to $requiredVars is fine on MySQL and Sqlite.

#Comment by Freakolowsky (talk | contribs)   21:05, 18 January 2011

nope ... i think it never did ... not sure

  • $wgDBserver as db descriptor names from tnsnames.ora
  • $wgDBname as target schema if not same as username

Status & tagging log