r80232 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r80231‎ | r80232 | r80233 >
Date:02:15, 14 January 2011
Author:dantman
Status:ok (Comments)
Tags:
Comment:
Support talk page tab messages like MediaWiki:Nstab-user_talk. Like the MediaWiki:Nstab-main MediaWiki:Nstab-user etc... we already support.
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
——@@ -833,7 +833,7 @@
834834 );
835835 $content_navigation['namespaces'][$subjectId]['context'] = 'subject';
836836 $content_navigation['namespaces'][$talkId] = $this->tabAction(
837 - $talkPage, 'talk', $isTalk && !$preventActiveTabs, '', $userCanRead
 837+ $talkPage, !wfEmptyMsg("nstab-$talkId") ? "nstab-$talkId" : 'talk', $isTalk && !$preventActiveTabs, '', $userCanRead
838838 );
839839 $content_navigation['namespaces'][$talkId]['context'] = 'talk';
840840

Comments

#Comment by 😂 (talk | contribs)   15:21, 2 June 2011

Don't really like the inline ternary, it's hard on the eyes. Otherwise ok.

Status & tagging log