r80220 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80219‎ | r80220 | r80221 >
Date:00:46, 14 January 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
whitespace clean up in shared.css
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -715,7 +715,7 @@
716716 background-color: #ccccff;
717717 }
718718
719 - /* Allmessages table */
 719+/* Allmessages table */
720720 #mw-allmessagestable .allmessages-customised td.am_default {
721721 background-color: #fcffc4;
722722 }
@@ -930,7 +930,30 @@
931931 border: 1px solid #5dc9f4;
932932 margin-left: 20px;
933933 }
934 -.tipsy { padding: 5px 5px 10px; font-size: 12px; position: absolute; z-index: 100000; overflow: visible; }
935 -.tipsy-inner { padding: 5px 8px 4px 8px; background-color: #d6f3ff; color: black; border: 1px solid #5dc9f4; max-width: 300px; text-align: left; }
936 -.tipsy-arrow { position: absolute; /* @embed */ background: url( 'images/tipsy-arrow.gif' ) no-repeat top left; width: 13px; height: 13px; }
937 -.tipsy-se .tipsy-arrow { bottom: -2px; right: 10px; background-position: 0% 100%; }
 934+.tipsy {
 935+ padding: 5px 5px 10px;
 936+ font-size: 12px;
 937+ position: absolute;
 938+ z-index: 100000;
 939+ overflow: visible;
 940+}
 941+.tipsy-inner {
 942+ padding: 5px 8px 4px 8px;
 943+ background-color: #d6f3ff;
 944+ color: black;
 945+ border: 1px solid #5dc9f4;
 946+ max-width: 300px;
 947+ text-align: left;
 948+}
 949+.tipsy-arrow {
 950+ position: absolute;
 951+ /* @embed */
 952+ background: url( 'images/tipsy-arrow.gif' ) no-repeat top left;
 953+ width: 13px;
 954+ height: 13px;
 955+}
 956+.tipsy-se .tipsy-arrow {
 957+ bottom: -2px;
 958+ right: 10px;
 959+ background-position: 0% 100%;
 960+}

Comments

#Comment by Hashar (talk | contribs)   12:45, 17 January 2011

Should we bump $wgStyleVersion for whitespaces / comments changes in CSS / JS?

#Comment by TheDJ (talk | contribs)   13:44, 17 January 2011

No, for whitespace and comment it is not required. Only functional changes.

#Comment by Hashar (talk | contribs)   18:55, 17 January 2011

Make sens, thanks. Marked 'ok'.

#Comment by Catrope (talk | contribs)   18:01, 18 January 2011

This is not needed for files managed by the resource loader.

Status & tagging log