r80195 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80194‎ | r80195 | r80196 >
Date:22:08, 13 January 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fixing up spaces to tabs in r80192

Removing trailing whitespace
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -25,11 +25,11 @@
2626 // <meta keyworkds="stuff"> most of the time the first 10 links to an article
2727 var $mKeywords = array();
2828
29 - var $mLinktags = array();
 29+ var $mLinktags = array();
3030
3131 // additional stylesheets. Looks like this is for extensions. Might be replaced by ressource loader.
3232 var $mExtStyles = array();
33 -
 33+
3434 // should be private. We got set/get accessors. Set the HTML title
3535 var $mPagetitle = '';
3636
@@ -69,7 +69,7 @@
7070 // mLastModified and mEtag are used for sending cache control.
7171 // The whole caching system should probably be moved in its own class.
7272 var $mLastModified = '';
73 -
 73+
7474 /*
7575 * Should be private. No getter but used in sendCacheControl();
7676 * Contains an HTTP Entity Tags (see RFC 2616 section 3.13) which is used
@@ -112,7 +112,7 @@
113113 // Next variables probably comes from the ressource loader @todo FIXME
114114 var $mModules = array(), $mModuleScripts = array(), $mModuleStyles = array(), $mModuleMessages = array();
115115 var $mResourceLoader;
116 -
 116+
117117 /** @fixme is this still used ?*/
118118 var $mInlineMsg = array();
119119
@@ -1524,7 +1524,7 @@
15251525 continue;
15261526 } else {
15271527 $aloption[] = 'string-contains=' . $variant;
1528 -
 1528+
15291529 // IE and some other browsers use another form of language code
15301530 // in their Accept-Language header, like "zh-CN" or "zh-TW".
15311531 // We should handle these too.
@@ -2385,17 +2385,17 @@
23862386 if ( $wgRequest->getBool( 'handheld' ) ) {
23872387 $query['handheld'] = 1;
23882388 }
2389 -
 2389+
23902390 if ( !count( $modules ) ) {
23912391 return '';
23922392 }
2393 -
 2393+
23942394 if ( count( $modules ) > 1 ) {
23952395 // Remove duplicate module requests
23962396 $modules = array_unique( (array) $modules );
23972397 // Sort module names so requests are more uniform
23982398 sort( $modules );
2399 -
 2399+
24002400 if ( ResourceLoader::inDebugMode() ) {
24012401 // Recursively call us for every item
24022402 $links = '';
@@ -2405,7 +2405,7 @@
24062406 return $links;
24072407 }
24082408 }
2409 -
 2409+
24102410 // Create keyed-by-group list of module objects from modules list
24112411 $groups = array();
24122412 $resourceLoader = $this->getResourceLoader();
@@ -2535,7 +2535,7 @@
25362536 if ( !$userOptionsAdded ) {
25372537 $scripts .= $this->makeResourceLoaderLink( $sk, 'user.options', 'scripts' );
25382538 }
2539 -
 2539+
25402540 return $scripts;
25412541 }
25422542

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80192OutputPage properties documentation...hashar21:08, 13 January 2011

Comments

#Comment by Hashar (talk | contribs)   07:16, 14 January 2011

Thanks \o/

Status & tagging log