r80115 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r80114‎ \| r80115 \| r80116 >
Date:	20:39, 12 January 2011
Author:	tparscal
Status:	ok
Tags:
Comment:	Fixed IE bug, you must use html:msg for the msg elements that jquery.localize uses to translate things otherwise IE chokes when you insert them cause it doesn't know about the msg element.
Modified paths:	/trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
—	—	@@ -12,16 +12,16 @@
13	13	'ui': '\
14	14	<div class="articleFeedback-panel">\
15	15	<div class="articleFeedback-buffer">\
16		~~- <div class="articleFeedback-switch articleFeedback-switch-report articleFeedback-visibleWith-form" rel="report"><msg key="report-switch-label" /></div>\~~
17		~~- <div class="articleFeedback-switch articleFeedback-switch-form articleFeedback-visibleWith-report" rel="form"><msg key="form-switch-label" /></div>\~~
18		~~- <div class="articleFeedback-title articleFeedback-visibleWith-form"><msg key="form-panel-title" /></div>\~~
19		~~- <div class="articleFeedback-title articleFeedback-visibleWith-report"><msg key="report-panel-title" /></div>\~~
20		~~- <div class="articleFeedback-instructions articleFeedback-visibleWith-form"><msg key="form-panel-instructions" /></div>\~~
21		~~- <div class="articleFeedback-description articleFeedback-visibleWith-report"><msg key="report-panel-description" /></div>\~~
	16	+ <div class="articleFeedback-switch articleFeedback-switch-report articleFeedback-visibleWith-form" rel="report"><html:msg key="report-switch-label" /></div>\
	17	+ <div class="articleFeedback-switch articleFeedback-switch-form articleFeedback-visibleWith-report" rel="form"><html:msg key="form-switch-label" /></div>\
	18	+ <div class="articleFeedback-title articleFeedback-visibleWith-form"><html:msg key="form-panel-title" /></div>\
	19	+ <div class="articleFeedback-title articleFeedback-visibleWith-report"><html:msg key="report-panel-title" /></div>\
	20	+ <div class="articleFeedback-instructions articleFeedback-visibleWith-form"><html:msg key="form-panel-instructions" /></div>\
	21	+ <div class="articleFeedback-description articleFeedback-visibleWith-report"><html:msg key="report-panel-description" /></div>\
22	22	<div style="clear:both;"></div>\
23	23	<div class="articleFeedback-ratings"></div>\
24	24	<div style="clear:both;"></div>\
25		~~- <button class="articleFeedback-submit articleFeedback-visibleWith-form" type="submit" disabled><msg key="form-panel-submit" /></button>\~~
	25	+ <button class="articleFeedback-submit articleFeedback-visibleWith-form" type="submit" disabled><html:msg key="form-panel-submit" /></button>\
26	26	<div style="clear:both;"></div>\
27	27	</div>\
28	28	</div>\

Status & tagging log

01:57, 19 January 2011 Catrope (talk | contribs) changed the tags for r80115 [removed: 1.17]
21:03, 12 January 2011 Catrope (talk | contribs) changed the tags for r80115 [added: 1.17]
21:03, 12 January 2011 Catrope (talk | contribs) changed the status of r80115 [removed: new added: ok]