r80114 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80113‎ | r80114 | r80115 >
Date:20:24, 12 January 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r80008: initialize $canCreateNew as an array, cause that's what it is
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/Thread.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/Thread.php
@@ -1562,7 +1562,7 @@
15631563 public static function canUserCreateThreads( $user ) {
15641564 $userText = $user->getName();
15651565
1566 - static $canCreateNew = null;
 1566+ static $canCreateNew = array();
15671567 if ( !isset( $canCreateNew[$userText] ) ) {
15681568 $title = Title::makeTitleSafe( NS_LQT_THREAD, 'Test title for LQT thread creation check' );
15691569 $canCreateNew[$userText] = $title->userCan( 'create' ) && $title->userCan( 'edit' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80008Attack on query bloat. The permissions checks were doing few hundred queries ...nikerabbit14:17, 11 January 2011

Status & tagging log