r80006 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80005‎ | r80006 | r80007 >
Date:13:54, 11 January 2011
Author:demon
Status:resolved
Tags:
Comment:
Fix callback issue noted in r79989 (broken in r78774).
$this makes a difference.
I'm an idiot.
Modified paths:
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/PostgresInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -354,7 +354,7 @@
355355 foreach( $this->extraInstallSteps as $step ) {
356356 // Put the step at the beginning
357357 if( !strval( $step['position' ] ) ) {
358 - array_unshift( $installSteps, $step['callback'] );
 358+ array_unshift( $this->installSteps, $step['callback'] );
359359 continue;
360360 } else {
361361 // Walk the $coreInstallSteps array to see if we can modify
Index: trunk/phase3/includes/installer/PostgresInstaller.php
@@ -193,25 +193,20 @@
194194 'name' => 'pg-commit',
195195 'callback' => array( $this, 'commitChanges' ),
196196 );
197 -/* $userCB = array(
 197+ $userCB = array(
198198 'name' => 'user',
199199 'callback' => array( $this, 'setupUser' ),
200 - ); */
 200+ );
201201 $ts2CB = array(
202202 'name' => 'pg-ts2',
203203 'callback' => array( $this, 'setupTs2' ),
204204 );
205205 $this->parent->addInstallStep( $commitCB, 'interwiki' );
206 -// $this->parent->addInstallStep( $userCB );
 206+ $this->parent->addInstallStep( $userCB );
207207 $this->parent->addInstallStep( $ts2CB, 'setupDatabase' );
208208 }
209209
210210 function setupDatabase() {
211 - $status = $this->setupUser();
212 - if (!$status->isOK() ) {
213 - return $status;
214 - }
215 -
216211 $status = $this->getConnection();
217212 if ( !$status->isOK() ) {
218213 return $status;

Follow-up revisions

RevisionCommit summaryAuthorDate
r81182MFT a bunch of installer fixes. r80238, r80128, r80124, r80083, r80080, r800...demon01:59, 29 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78774Rewrite install steps again (cleanup r76390)...demon05:21, 22 December 2010
r79989I have no clue how the callbacks work, this at least sets up a database, ever...overlordq03:07, 11 January 2011

Status & tagging log