r79947 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79946‎ | r79947 | r79948 >
Date:18:47, 10 January 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
rv r78076
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
——@@ -197,7 +197,7 @@
198198 * @return int Number of revisions
199199 */
200200 function getRevCount( $dbr ) {
201 - /*$tables = array( 'code_rev' );
 201+ $tables = array( 'code_rev' );
202202 $selectFields = array( 'COUNT( DISTINCT cr_id ) AS rev_count' );
203203 // Count if code_rev where path matches
204204 if ( strlen( $this->mPath ) ) {
——@@ -220,8 +220,6 @@
221221 } else {
222222 return 0;
223223 }
224 - */
225 - return mt_rand( 0, $this->mRepo->getLastStoredRev() );
226224 }
227225
228226 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78076Until someone bothers fixing this inaccurate counting something, return somet...demon17:07, 8 December 2010

Comments

#Comment by Nikerabbit (talk | contribs)   18:50, 10 January 2011

Why?

#Comment by 😂 (talk | contribs)   18:51, 10 January 2011

I was told that returning this wasn't the right fix for the problem.

He says he's fixing it, and I have no intention of working on this any more right now.

#Comment by Reedy (talk | contribs)   18:51, 10 January 2011

Well, it was hardly a "fix" to the issue ;)

Status & tagging log