r79930 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79929‎ | r79930 | r79931 >
Date:08:33, 10 January 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Be sure to use the latest rev id and not whatever getRevIdFetched() could be
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -2211,7 +2211,7 @@
22122212 $status->warning( 'edit-no-change' );
22132213 $revision = null;
22142214 // Keep the same revision ID, but do some updates on it
2215 - $revisionId = $this->getRevIdFetched();
 2215+ $revisionId = $this->getLatest();
22162216 // Update page_touched, this is usually implicit in the page update
22172217 // Other cache updates are done in onArticleEdit()
22182218 $this->mTitle->invalidateCache();

Comments

#Comment by Aaron Schulz (talk | contribs)   23:26, 14 June 2011

This whole class really needs to be split into a View and a DAO class.

Status & tagging log