r79884 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79883‎ | r79884 | r79885 >
Date:11:30, 9 January 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
* (bug 26187) Confirmrecreate no longer parses the edit summary
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1273,9 +1273,14 @@
12741274 $this->showFormBeforeText();
12751275
12761276 if ( $this->wasDeletedSinceLastEdit() && 'save' == $this->formtype ) {
 1277+ $username = $this->lastDelete->user_name;
 1278+ $comment = $this->lastDelete->log_comment;
 1279+
 1280+ // It is better to not parse the comment at all than to have templates expanded in the middle
 1281+ // TODO: can the checkLabel be moved outside of the div so that wrapWikiMsg could be used?
12771282 $wgOut->addHTML(
12781283 '<div class="mw-confirm-recreate">' .
1279 - $wgOut->parse( wfMsg( 'confirmrecreate', $this->lastDelete->user_name , $this->lastDelete->log_comment ) ) .
 1284+ wfMsgExt( 'confirmrecreate', 'parseinline', $username, "<nowiki>$comment</nowiki>" ) ) .
12801285 Xml::checkLabel( wfMsg( 'recreate' ), 'wpRecreate', 'wpRecreate', false,
12811286 array( 'title' => $sk->titleAttrib( 'recreate' ), 'tabindex' => 1, 'id' => 'wpRecreate' )
12821287 ) .
Index: trunk/phase3/RELEASE-NOTES
@@ -66,6 +66,7 @@
6767 disabling upload protection by removing it from $wgRestrictionTypes.
6868 * If an edit summary exceeds 250 bytes and is truncated, add an ellipse
6969 * (bug 26638) Database error pages display correctly in RTL languages
 70+* (bug 26187) Confirmrecreate no longer parses the edit summary
7071
7172 === API changes in 1.18 ===
7273 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r79890Fix syntax terror from r79884nikerabbit12:23, 9 January 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   23:02, 14 June 2011

blarg...OK enough

Status & tagging log