r79807 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79806‎ | r79807 | r79808 >
Date:05:43, 7 January 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Allow CLI installer to set $whShowExceptionDetails
Modified paths:
  • /trunk/phase3/includes/installer/CliInstaller.php (modified) (history)
  • /trunk/phase3/maintenance/install.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/install.php
@@ -55,7 +55,7 @@
5656 $this->addOption( 'env-checks', "Run environment checks only, don't change anything" );
5757 $this->addOption( 'upgrade',
5858 'Allow the upgrade to continue despite an existing LocalSettings.php', false, true );
59 -
 59+ $this->addOption( 'showexceptions', "Whether to set wgShowExceptionDetails", false, true );
6060 }
6161
6262 public function execute() {
Index: trunk/phase3/includes/installer/CliInstaller.php
@@ -35,6 +35,7 @@
3636 'upgrade' => 'cliUpgrade', /* As long as it isn't $confItems
3737 * in LocalSettingsGenerator, we
3838 * should be fine. */
 39+ 'showexceptions' => 'wgShowExceptionDetails',
3940 );
4041
4142 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r79827Revert r79807reedy18:08, 7 January 2011

Comments

#Comment by Reedy (talk | contribs)   06:33, 7 January 2011

Screw you tesla/cruise control.

This doesn't work as expected. So I'm likely to revert it, unless Chad can help me do it properly...

#Comment by 😂 (talk | contribs)   06:57, 7 January 2011

What does this have to do with tesla?

#Comment by Reedy (talk | contribs)   07:10, 7 January 2011

Tesla was throwing exceptions.

Couldn't easily enable exception detail as it trashed local settings on every run.

Thought this may allow a way to have it dump the var to local settings. Seemingly not

Can we add a debug flag to cli installer to have it set all the default debug stuff?

#Comment by MaxSem (talk | contribs)   08:19, 7 January 2011
  1. Ask Mark or Chad for access to Tesla.
  2. Make local modifications to ExtraSettings.php
  3. ...
  4. PROFIT!
#Comment by Reedy (talk | contribs)   15:34, 7 January 2011

I've already access to tesla. ;)

Didn't even think of no 2

#Comment by MaxSem (talk | contribs)   16:19, 7 January 2011

So this revision can be reverted?

Status & tagging log